feature: Convert output_verbosity values to constants in PHP config
#1623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `->withOutputVerbosity` formatter config method in PHP is expected to take an `OutputVerbosity::VERBOSITY_*` constant value (as per the phpdoc for that method). If the user's YAML config contains one of the valid values as an integer we can convert it to a constant reference. This will make the PHP file clearer without e.g. needing a separate comment as might have been present in the YAML. If we don't recognise the value (it may be invalid, or e.g. an env var) then we just convert it as the original scalar value.
stof
approved these changes
Apr 15, 2025
carlos-granados
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
->withOutputVerbosityformatter config method in PHP is expected to take anOutputVerbosity::VERBOSITY_*constant value (as per the phpdoc for that method).If the user's YAML config contains one of the valid values as an integer we can convert it to a constant reference. This will make the PHP file clearer without e.g. needing a separate comment as might have been present in the YAML.
If we don't recognise the value (it may be invalid, or e.g. an env var) then we just convert it as the original scalar value.