Use the device pixel ratio for icon rendering #103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When fractional scaling is >100%. Icons inside buttons, dialog boxes etc are not rendered properly.
This leaves a slight roughness to how the icons are presented as the pixels are visibly more prevalent.
From what I gathered it seems close to the issues seen in #99
Leaving this as WIP for now since we need confirmation.
For example when Darkly is used with the default BreezeDark icons.
The pencil icon at the bottom right demonstrates this issue.
The icon beside the Details button and same issue is seen with OK and Cancel buttons.
These changes are taken directly from Breeze, and are mostly around the introduction of devicePixelRatio which was initially missing from Lightly as such this impacts any derivative forks. See https://doc.qt.io/qt-6/qpaintdevice.html#devicePixelRatio
A relog is required for the change to be applied properly.