Skip to content

Force blur update to also catch if alpha channel is 255 #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 29, 2024
Merged

Force blur update to also catch if alpha channel is 255 #90

merged 7 commits into from
Dec 29, 2024

Conversation

DeltaCopy
Copy link
Collaborator

To avoid the translucent background when showing/hiding the Menubar in Dolphin

@DeltaCopy DeltaCopy added transparency Transparency related issue blur Something wrong with the blur labels Dec 27, 2024
@DeltaCopy DeltaCopy mentioned this pull request Dec 27, 2024
Closed
@DeltaCopy DeltaCopy added needs testing Something needs testing in progress Something is work in progress and removed needs testing Something needs testing labels Dec 27, 2024
@DeltaCopy DeltaCopy changed the title Register blur on toolbar background control Force blur update to also catch if alpha channel is 255 Dec 28, 2024
@DeltaCopy
Copy link
Collaborator Author

The initial fix for #82 caused a regression, whereby the menubar was flickering upon hiding/showing.
Removed register blur from drawing the toolbar background, and ensured that if the alpha channel is 255 then force blur inside the event filter where it should be repainted.

@DeltaCopy DeltaCopy added the needs testing Something needs testing label Dec 28, 2024
@subhasutra
Copy link

This fixes the flickering for me. 👍🏼

@DeltaCopy DeltaCopy removed the needs testing Something needs testing label Dec 29, 2024
@DeltaCopy DeltaCopy marked this pull request as ready for review December 29, 2024 16:43
@DeltaCopy DeltaCopy merged commit 878ce7d into Bali10050:FeatureDarkly Dec 29, 2024
@DeltaCopy
Copy link
Collaborator Author

Thank you for testing again @subhasutra.

I have merged up into the feature branch.

@Bali10050
Copy link
Owner

Thank you @DeltaCopy for the fix!

@DeltaCopy DeltaCopy removed the in progress Something is work in progress label Dec 30, 2024
@DeltaCopy DeltaCopy deleted the bugfixes/toolbarblur branch January 2, 2025 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
blur Something wrong with the blur transparency Transparency related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DeltaCopy @subhasutra @Bali10050 @zspher