Fix context menu outline #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 28bfa2e changed the composition mode to Source when painting transparent context menus. On dark color schemes, there is a transparent outline painted on top of the menu background. The Source mode results in the outline replacing pixels of the background instead being painted on top. This commit changes the mode to SourceOver (default) before painting the outline, making context menus look like in v0.5.11. It doesn't break menu transparency, because it's changed only for the outline.
|
Nice job, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 28bfa2e changed the composition mode to Source when painting transparent context menus. On dark color schemes, there is a transparent outline painted on top of the menu background. The Source mode results in the outline replacing pixels of the background instead being painted on top.
This PR changes the mode to SourceOver (default) before painting the outline, making context menus look like in v0.5.11. It doesn't break menu transparency, because it's changed only for the outline.