Skip to content
This repository was archived by the owner on Aug 29, 2024. It is now read-only.

Conversation

shaundon
Copy link
Contributor

@shaundon shaundon commented Feb 4, 2024

Hi,

Here's a small PR to add a function for setting which UserDefaults suite to use. I'm using it in my own app to make use of Zephyr while using App Groups.

Example usage:

if let suite = UserDefaults(suiteName: "group.com.example.app-name") {
    Zephyr.setUserDefaultsSuite(to: suite)
}

I'm not sure if you accept external PRs – if this isn't something you're looking for then no worries. I'm also happy to update this PR to document it in the readme, but I figured I'd wait to see what you think before doing that.

@ArtSabintsev
Copy link
Owner

hey, feel free to update the docs and I'll merge this in. Thanks for the contribution!

@danielkramer
Copy link

I'm interested in this update as well!

@ArtSabintsev
Copy link
Owner

Sounds good - please update the docs in this PR and I'll happily merge it if you can confirm it works.

@shaundon
Copy link
Contributor Author

Sorry for the delay, I went on holiday right after making the initial PR. I've updated the readme now.

@shaundon
Copy link
Contributor Author

if you can confirm it works

I'm using it in production in my app SalaryPig and all seems to work well.

@ArtSabintsev
Copy link
Owner

Looks good! Will merge.

@ArtSabintsev ArtSabintsev merged commit b3882a7 into ArtSabintsev:master Mar 21, 2024
@danielkramer
Copy link

Thanks! Just to add, I've been using the update in an app I'm developing.. been using for a few weeks and no issues

@ArtSabintsev
Copy link
Owner

Great! I'll push via cocoa pods soon.

@ArtSabintsev
Copy link
Owner

Just released as v3.8.0

Closing this issue

@shaundon shaundon deleted the patch-1 branch March 23, 2024 10:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants