fix #2160 (studio login) #2162
Merged
fix #2160 (studio login) #2162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
studio/src/main/resources/static/js/studio-database.js:46
- Confirm that removing the data payload is intentional and that the backend endpoint 'api/v1/databases' does not require additional parameters previously sent with POST requests.
- data: "{ command: 'list databases' }",
studio/src/main/resources/static/js/studio-database.js:47
- Ensure that switching from POST to GET is compatible with the backend behavior and does not introduce side effects in how login credentials or session details are managed.
+ type: "GET",
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Studio Login fails due to use of removed
versionprop from HTTP responses.Motivation
#2160
Additional Notes
This only works because the
databasesendpoint still uses thecreateResultfor the JSON response including the version property.Checklist
mvn clean packagecommand