Skip to content

Feat: dynamic line stroke settings #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Feat: dynamic line stroke settings #396

wants to merge 2 commits into from

Conversation

adripo
Copy link
Contributor

@adripo adripo commented Nov 10, 2022

New feature to configure line type in the graph of the temperatures:
image
image
image

@codecov-commenter
Copy link

Codecov Report

Merging #396 (536b590) into master (a01b8fe) will decrease coverage by 0.18%.
The diff coverage is 27.83%.

@@            Coverage Diff             @@
##           master     #396      +/-   ##
==========================================
- Coverage   32.69%   32.50%   -0.19%     
==========================================
  Files          51       54       +3     
  Lines        2753     3049     +296     
  Branches       61       66       +5     
==========================================
+ Hits          900      991      +91     
- Misses       1821     2022     +201     
- Partials       32       36       +4
Flag Coverage Δ
unittests 32.50% <27.83%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
collector/pkg/collector/base.go 0.00% <ø> (ø)
webapp/backend/pkg/config/config.go 0.00% <0.00%> (ø)
webapp/backend/pkg/database/scrutiny_repository.go 12.60% <0.00%> (-0.92%) ⬇️
...end/pkg/database/scrutiny_repository_migrations.go 0.00% <0.00%> (ø)
...ckend/pkg/database/scrutiny_repository_settings.go 0.00% <0.00%> (ø)
webapp/frontend/src/app/layout/layout.component.ts 2.50% <20.00%> (ø)
...end/src/app/core/config/scrutiny-config.service.ts 42.85% <42.85%> (ø)
...bapp/frontend/src/app/shared/device-status.pipe.ts 64.70% <62.50%> (+54.70%) ⬆️
webapp/frontend/src/app/shared/file-size.pipe.ts 78.57% <76.92%> (-6.05%) ⬇️
...mon/dashboard-device/dashboard-device.component.ts 73.07% <80.00%> (+17.52%) ⬆️
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@adripo adripo mentioned this pull request Nov 14, 2022
Closed
@AnalogJ
Copy link
Owner

AnalogJ commented Nov 22, 2022

Hey @adripo can you confirm that my changes worked for you?

@AnalogJ AnalogJ mentioned this pull request Apr 6, 2023
Merged
@AnalogJ AnalogJ closed this in #470 Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adripo @codecov-commenter @AnalogJ