Skip to content

Conversation

drroe
Copy link
Contributor

@drroe drroe commented Feb 11, 2021

Will tell nastruct to calculate parameters between consecutive bases in strands.

@drroe drroe self-assigned this Feb 11, 2021
@lgtm-com
Copy link

lgtm-com bot commented Feb 11, 2021

This pull request introduces 1 alert when merging 0cba11e into bf27656 - view on LGTM.com

new alerts:

  • 1 for FIXME comment

@drroe
Copy link
Contributor Author

drroe commented Feb 11, 2021

@swails The Jenkins build appears to be stuck on the libcpptraj build at a prompt:

[2021-02-11T16:53:49.184Z] Please select the geographic area in which you live. Subsequent configuration
[2021-02-11T16:53:49.184Z] questions will narrow this down by presenting a list of cities, representing
[2021-02-11T16:53:49.184Z] the time zones in which they are located.

@lgtm-com
Copy link

lgtm-com bot commented Feb 11, 2021

This pull request fixes 26 alerts when merging 2e0ecb4 into bf27656 - view on LGTM.com

fixed alerts:

  • 26 for FIXME comment

@drroe
Copy link
Contributor Author

drroe commented Feb 11, 2021

Jenkins build is hanging on libcpptraj. Will test manually with pytraj locally. If that passes I'll merge. Making the Actions tests required instead of Jenkins.

@drroe
Copy link
Contributor Author

drroe commented Feb 11, 2021

Pytraj tests are good:

========================== 409 passed, 40 skipped, 50 warnings in 27.83s ===========================

Going to merge.

@drroe drroe merged commit 74b5c2a into Amber-MD:master Feb 11, 2021
@drroe drroe deleted the nastruct.ss branch February 11, 2021 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant