Skip to content

refactor(wow-core): introduce WaitStrategy.FunctionMaterialized interface #1843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 6, 2025
Merged

refactor(wow-core): introduce WaitStrategy.FunctionMaterialized interface #1843

merged 1 commit into from
Aug 6, 2025

Conversation

Ahoo-Wang
Copy link
Owner

  • Extract common functionality into a new interface FunctionMaterialized
  • Simplify the Materialized class in WaitingForStage
  • Improve code organization and reusability

@Ahoo-Wang
refactor(wow-core): introduce WaitStrategy.FunctionMaterialized inter…
f81dc5b 
…face

- Extract common functionality into a new interface FunctionMaterialized
- Simplify the Materialized class in WaitingForStage
- Improve code organization and reusability

Signed-off-by: Ahoo Wang <ahoowang@qq.com>
@Ahoo-Wang Ahoo-Wang added the enhancement New feature or request label Aug 6, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 6, 2025 •
edited
Loading

Test Results

1 475 tests  ±0   1 458 ✅ ±0   12m 35s ⏱️ +22s
  369 suites ±0      17 💤 ±0 
  369 files   ±0       0 ❌ ±0 

Results for commit f81dc5b. ± Comparison against base commit a8d3bd0.

♻️ This comment has been updated with latest results.

@codecov Codecov
Copy link

codecov bot commented Aug 6, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 38.46154% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.04%. Comparing base (a8d3bd0) to head (f81dc5b).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...in/kotlin/me/ahoo/wow/command/wait/WaitStrategy.kt 33.33% 7 Missing and 1 partial ⚠️

❌ Your patch status has failed because the patch coverage (38.46%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #1843      +/-   ##
============================================
- Coverage     91.08%   91.04%   -0.05%     
  Complexity     3723     3723              
============================================
  Files           704      704              
  Lines         12869    12875       +6     
  Branches        819      819              
============================================
  Hits          11722    11722              
- Misses          754      760       +6     
  Partials        393      393
Flag Coverage Δ
unittests 91.04% <38.46%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Ahoo-Wang Ahoo-Wang merged commit 54101c5 into main Aug 6, 2025
32 of 33 checks passed
@Ahoo-Wang Ahoo-Wang deleted the FunctionMaterialized branch August 6, 2025 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Ahoo-Wang