refactor(wow-core): optimize command wait strategy and propagation #1840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Ahoo-Wang
commented
Aug 6, 2025
- Simplify command wait ID propagation logic
- Enhance WaitStrategy interface with shouldPropagate method
- Refactor WaitStrategyPropagator to better handle message propagation- Update command wait notifier and related classes to use new logic
- Add unit tests for new command wait propagation behavior
- Simplify command wait ID propagation logic - Enhance WaitStrategy interface with shouldPropagate method - Refactor WaitStrategyPropagator to better handle message propagation- Update command wait notifier and related classes to use new logic - Add unit tests for new command wait propagation behavior Signed-off-by: Ahoo Wang <ahoowang@qq.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1840 +/- ##
============================================
- Coverage 91.07% 91.04% -0.03%
- Complexity 3719 3723 +4
============================================
Files 704 704
Lines 12871 12876 +5
Branches 820 819 -1
============================================
+ Hits 11722 11723 +1
- Misses 756 760 +4
Partials 393 393
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.