refactor(wow-core): enhance waitingLast() to aggregate signals #1847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Ahoo-Wang
commented
Aug 6, 2025
- Update waitingLast() method to collect and sort all signals
- Aggregate results from all signals before returning the last one
- Improve handling of multiple signals in wait strategies
- Update waitingLast() method to collect and sort all signals - Aggregate results from all signals before returning the last one - Improve handling of multiple signals in wait strategies Signed-off-by: Ahoo Wang <ahoowang@qq.com>
…ated tests - Move waitingLast() implementation from WaitStrategy to WaitingFor - Update SimpleWaitingForChainTest with new waitingLast() tests - Modify WaitingForAfterProcessed to use the new waitingLast() method - Remove redundant waitingLast() implementation from WaitStrategy Signed-off-by: Ahoo Wang <ahoowang@qq.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1847 +/- ##
=========================================
Coverage 91.15% 91.16%
- Complexity 3751 3752 +1
=========================================
Files 707 707
Lines 13026 13034 +8
Branches 836 836
=========================================
+ Hits 11874 11882 +8
+ Misses 759 758 -1
- Partials 393 394 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Add new test function `waitingLastEmpty` to cover scenario when waiting for stage is empty - Ensure cancel status is false and terminate status is false before completing - Verify that the waiting last operation completes successfully Signed-off-by: Ahoo Wang <ahoowang@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.