refactor(wow): rename commandWaitId to waitCommandId #1837
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Ahoo-Wang
commented
Aug 5, 2025
- Rename commandWaitId to waitCommandId in various classes and methods
- Update related tests to use new waitCommandId naming
- Modify command sent signal method to use waitCommandId instead of commandWaitId
- Update wait strategy registration and propagation to use waitCommandId
- Rename commandWaitId to waitCommandId in various classes and methods - Update related tests to use new waitCommandId naming - Modify command sent signal method to use waitCommandId instead of commandWaitId - Update wait strategy registration and propagation to use waitCommandId Signed-off-by: Ahoo Wang <ahoowang@qq.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1837 +/- ##
============================================
- Coverage 91.09% 91.07% -0.02%
+ Complexity 3719 3716 -3
============================================
Files 702 702
Lines 12874 12871 -3
Branches 819 820 +1
============================================
- Hits 11727 11722 -5
- Misses 755 756 +1
- Partials 392 393 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.