Skip to content

refactor(wow-core): move message propagation logic #1835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 5, 2025
Merged

refactor(wow-core): move message propagation logic #1835

merged 1 commit into from
Aug 5, 2025

Conversation

Ahoo-Wang
Copy link
Owner

  • Move propagate(header: Header, upstream: Message<*, *>) method from WaitingForStage to WaitStrategy
  • Remove redundant import statements in WaitingForStage.kt

@Ahoo-Wang
refactor(wow-core): move message propagation logic
13be4b9 
- Move propagate(header: Header, upstream: Message<*, *>) method from WaitingForStage to WaitStrategy
- Remove redundant import statements in WaitingForStage.kt

Signed-off-by: Ahoo Wang <ahoowang@qq.com>
@Ahoo-Wang Ahoo-Wang added the enhancement New feature or request label Aug 5, 2025
@Ahoo-Wang Ahoo-Wang merged commit 5aa6f45 into main Aug 5, 2025
30 checks passed
@Ahoo-Wang Ahoo-Wang deleted the propagate branch August 5, 2025 08:23
@codecov Codecov
Copy link

codecov bot commented Aug 5, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.08%. Comparing base (b0d50db) to head (13be4b9).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...in/kotlin/me/ahoo/wow/command/wait/WaitStrategy.kt 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #1835      +/-   ##
============================================
+ Coverage     91.07%   91.08%   +0.01%     
- Complexity     3715     3718       +3     
============================================
  Files           702      702              
  Lines         12868    12871       +3     
  Branches        819      819              
============================================
+ Hits          11719    11724       +5     
+ Misses          756      755       -1     
+ Partials        393      392       -1
Flag Coverage Δ
unittests 91.08% <66.66%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Ahoo-Wang