refactor(wow-core): replace contextName, processorName, functionName with function object #1827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Ahoo-Wang
commented
Aug 5, 2025
- Introduce NamedFunctionInfoData to encapsulate function information
- Update WaitingForFunction and related classes to use NamedFunctionInfoData
- Modify isWaitingForFunction to use NamedFunctionInfoData
- Adjust WaitingForStage.Materialized to handle function information
- Update related tests to accommodate the new structure
…with function object - Introduce NamedFunctionInfoData to encapsulate function information - Update WaitingForFunction and related classes to use NamedFunctionInfoData - Modify isWaitingForFunction to use NamedFunctionInfoData - Adjust WaitingForStage.Materialized to handle function information - Update related tests to accommodate the new structure Signed-off-by: Ahoo Wang <ahoowang@qq.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1827 +/- ##
============================================
- Coverage 91.23% 91.21% -0.02%
+ Complexity 3721 3715 -6
============================================
Files 702 702
Lines 12832 12827 -5
Branches 815 817 +2
============================================
- Hits 11707 11700 -7
- Misses 738 739 +1
- Partials 387 388 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Implement comprehensive tests for the isWaitingForFunction method - Cover various scenarios including null values, empty fields, and partial matches - Ensure thorough testing of function matching logic Signed-off-by: Ahoo Wang <ahoowang@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.