refactor(wow-api): enhance ErrorInfo with toDefault conversion and default errorMsg #1813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Ahoo-Wang
commented
Jul 31, 2025
- Add toDefault() extension function to convert ErrorInfo to DefaultErrorInfo
- Update create method to return DefaultErrorInfo instead of ErrorInfo
- Set default empty string value for errorMsg in DefaultErrorInfo
…fault errorMsg - Add toDefault() extension function to convert ErrorInfo to DefaultErrorInfo - Update create method to return DefaultErrorInfo instead of ErrorInfo - Set default empty string value for errorMsg in DefaultErrorInfo Signed-off-by: Ahoo Wang <ahoowang@qq.com>
- Added subscribeOn(Schedulers.parallel()) to the send(message) call in CommandGatewaySpec.kt - This change ensures that the message sending is executed concurrently, improving test reliability Signed-off-by: Ahoo Wang <ahoowang@qq.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1813 +/- ##
============================================
+ Coverage 91.22% 91.23% +0.01%
Complexity 3714 3714
============================================
Files 701 701
Lines 12810 12818 +8
Branches 812 814 +2
============================================
+ Hits 11686 11695 +9
+ Misses 736 735 -1
Partials 388 388
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…tests - Removed the verifyWaitStrategyDestroyed function call from the CommandGatewaySpec test file - This change simplifies the test case and removes a potentially redundant check Signed-off-by: Ahoo Wang <ahoowang@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.