feat(wow-core): add command size information to WaitSignal #1811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Ahoo-Wang
commented
Jul 31, 2025
- Add getCommandSize() method to MonoCommandWaitNotifier
- Update WaitSignal interface and SimpleWaitSignal class to include commandSize
- This enhancement allows tracking the number of commands emitted by Saga
- Add getCommandSize() method to MonoCommandWaitNotifier - Update WaitSignal interface and SimpleWaitSignal class to include commandSize - This enhancement allows tracking the number of commands emitted by Saga Signed-off-by: Ahoo Wang <ahoowang@qq.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1811 +/- ##
============================================
+ Coverage 91.22% 91.24% +0.02%
- Complexity 3714 3715 +1
============================================
Files 701 701
Lines 12810 12818 +8
Branches 812 814 +2
============================================
+ Hits 11686 11696 +10
+ Misses 736 734 -2
Partials 388 388
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ream and waiting for stage - Add command stream and waiting for stage logic to the test - Use MockAggregateCreated event instead of mock - Propagate saga handled context - Verify command stream size Signed-off-by: Ahoo Wang <ahoowang@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.