Skip to content

fix(wow-core): handle waiting for signal logic #1808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 31, 2025
Merged

fix(wow-core): handle waiting for signal logic #1808

merged 2 commits into from
Jul 31, 2025

Conversation

Ahoo-Wang
Copy link
Owner

  • Update copyResult logic to properly handle waitingForSignal case
  • Improve null safety by using elvis operator to return last signal's result

@Ahoo-Wang
fix(wow-core): handle waiting for signal logic
506d8ae 
- Update copyResult logic to properly handle waitingForSignal case
- Improve null safety by using elvis operator to return last signal's result

Signed-off-by: Ahoo Wang <ahoowang@qq.com>
@Ahoo-Wang Ahoo-Wang added the enhancement New feature or request label Jul 31, 2025
@Ahoo-Wang
test(wow-schema): update OpenAPISchemaBuilderTest for SimpleWaitSigna…
f4e2adc 
…l schema

- Adjust the expected size of componentsSchemas from 6 to7 in the unit test

Signed-off-by: Ahoo Wang <ahoowang@qq.com>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 31, 2025 •
edited
Loading

Test Results

1 468 tests  +718   1 451 ✅ +712   11m 23s ⏱️ + 4m 44s
  368 suites +183      17 💤 +  9 
  368 files   +183       0 ❌  -   3 

Results for commit f4e2adc. ± Comparison against base commit b63fa60.

♻️ This comment has been updated with latest results.

@codecov Codecov
Copy link

codecov bot commented Jul 31, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.22%. Comparing base (e16c85b) to head (f4e2adc).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #1808      +/-   ##
============================================
- Coverage     91.23%   91.22%   -0.01%     
- Complexity     3712     3714       +2     
============================================
  Files           701      701              
  Lines         12807    12812       +5     
  Branches        811      812       +1     
============================================
+ Hits          11684    11688       +4     
- Misses          735      736       +1     
  Partials        388      388
Flag Coverage Δ
unittests 91.22% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Ahoo-Wang Ahoo-Wang merged commit c3cc500 into main Jul 31, 2025
32 of 34 checks passed
@Ahoo-Wang Ahoo-Wang deleted the handle-waiting-for-signal-logic branch July 31, 2025 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Ahoo-Wang