refactor(wow-core): improve wait strategy notification logic #1804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Ahoo-Wang
commented
Jul 30, 2025
- Update CommandWaitNotifier to use new notification logic
- Refactor WaitingForAfterProcessed to use isWaitingFor method
- Modify WaitingForFunction to use isWaitingForFunction extension function
- Update WaitingForProjected to use isWaitingFor method
- Add new WaitingFors file with isWaitingForFunction extension function
- Update WaitingForStage to use new waiting logic
- Update CommandWaitNotifier to use new notification logic - Refactor WaitingForAfterProcessed to use isWaitingFor method - Modify WaitingForFunction to use isWaitingForFunction extension function - Update WaitingForProjected to use isWaitingFor method - Add new WaitingFors file with isWaitingForFunction extension function - Update WaitingForStage to use new waiting logic Signed-off-by: Ahoo Wang <ahoowang@qq.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1804 +/- ##
============================================
- Coverage 91.22% 91.22% -0.01%
+ Complexity 3713 3711 -2
============================================
Files 700 701 +1
Lines 12798 12807 +9
Branches 810 811 +1
============================================
+ Hits 11675 11683 +8
Misses 736 736
- Partials 387 388 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.