Skip to content

refactor(prepare): introduce ApplicationBasePackageScanner for base package resolution #1798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 29, 2025
Merged

refactor(prepare): introduce ApplicationBasePackageScanner for base package resolution #1798

merged 1 commit into from
Jul 29, 2025

Conversation

Ahoo-Wang
Copy link
Owner

  • Add ApplicationBasePackageScanner class to handle base package scanning
  • Update PrepareAutoConfiguration to include ApplicationBasePackageScanner bean
  • Modify PrepareKeyAutoRegistrar to use ApplicationBasePackageScanner for base package resolution
  • Update tests to reflect new base package scanning approach

@Ahoo-Wang
refactor(prepare): introduce ApplicationBasePackageScanner for base p…
8cb0956 
…ackage resolution

- Add ApplicationBasePackageScanner class to handle base package scanning
- Update PrepareAutoConfiguration to include ApplicationBasePackageScanner bean
- Modify PrepareKeyAutoRegistrar to use ApplicationBasePackageScanner for base package resolution
- Update tests to reflect new base package scanning approach

Signed-off-by: Ahoo Wang <ahoowang@qq.com>
@Ahoo-Wang Ahoo-Wang added the enhancement New feature or request label Jul 29, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 29, 2025 •
edited
Loading

Test Results

1 468 tests  ±0   1 451 ✅ ±0   12m 54s ⏱️ + 1m 21s
  368 suites ±0      17 💤 ±0 
  368 files   ±0       0 ❌ ±0 

Results for commit 8cb0956. ± Comparison against base commit 4420729.

♻️ This comment has been updated with latest results.

@codecov Codecov
Copy link

codecov bot commented Jul 29, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 93.02326% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.23%. Comparing base (4420729) to head (8cb0956).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...t/starter/prepare/ApplicationBasePackageScanner.kt 92.10% 0 Missing and 3 partials ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #1798      +/-   ##
============================================
+ Coverage     91.21%   91.23%   +0.01%     
- Complexity     3706     3714       +8     
============================================
  Files           699      700       +1     
  Lines         12770    12795      +25     
  Branches        808      810       +2     
============================================
+ Hits          11648    11673      +25     
+ Misses          736      735       -1     
- Partials        386      387       +1
Flag Coverage Δ
unittests 91.23% <93.02%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Ahoo-Wang Ahoo-Wang merged commit 60ea648 into main Jul 29, 2025
33 checks passed
@Ahoo-Wang Ahoo-Wang deleted the ApplicationBasePackageScanner branch July 29, 2025 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Ahoo-Wang