Skip to content

Support aarch64-darwin #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Support aarch64-darwin #518

wants to merge 1 commit into from

Conversation

simonjwright
Copy link

Update the knowledge base by adding aarch64-darwin entries.

The new entries are edited copies of the x86_64-darwin entries; but note these possibly-doubtful aspects.

(BUILD_TARGETS): possible clash with aarch64-ios?
(HOST_GUESS): yes, uname -m really does return arm64.

@simonjwright
Support aarch64-darwin
bef9cd9 
  * src/e3/platform_db/knowledge_base.py: add aarch64-darwin entries
      as edited copies of the x86_64-darwin entries.
    (BUILD_TARGETS): possible clash with aarch64-ios?
    (BUILD_TARGETS): yes, uname -m really does return arm64.
@CLAassistant
Copy link

CLAassistant commented Apr 29, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Apr 29, 2022 •
edited
Loading

Codecov Report

Merging #518 (bef9cd9) into master (4d3b68d) will decrease coverage by 0.72%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #518      +/-   ##
==========================================
- Coverage   93.34%   92.62%   -0.73%     
==========================================
  Files          81       81              
  Lines        6644     6451     -193     
  Branches     1352     1257      -95     
==========================================
- Hits         6202     5975     -227     
- Misses        280      320      +40     
+ Partials      162      156       -6
Impacted Files Coverage Δ
src/e3/platform_db/knowledge_base.py 100.00% <ø> (ø)
src/e3/os/timezone.py 78.94% <0.00%> (-15.79%) ⬇️
src/e3/main.py 82.35% <0.00%> (-9.81%) ⬇️
src/e3/os/fs.py 90.32% <0.00%> (-6.11%) ⬇️
src/e3/sys.py 83.76% <0.00%> (-4.95%) ⬇️
src/e3/vcs/svn.py 85.18% <0.00%> (-4.20%) ⬇️
src/e3/anod/checkout.py 93.27% <0.00%> (-3.39%) ⬇️
src/e3/archive.py 93.24% <0.00%> (-3.38%) ⬇️
src/e3/fs.py 89.60% <0.00%> (-3.04%) ⬇️
src/e3/date.py 75.00% <0.00%> (-2.78%) ⬇️
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d3b68d...bef9cd9. Read the comment docs.

@simonjwright
Copy link
Author

The second [BUILD_TARGET] in the commit should have been [HOST_GUESS].

@simonjwright simonjwright mentioned this pull request May 1, 2022
Open
@enzbang enzbang requested a review from Nikokrock June 22, 2022 14:32
@enzbang
Copy link
Member

enzbang commented Oct 18, 2022

Hi, first thank you for your contribution. A teammate just told me that it is exactly the same as the one that we have just validated #532

We missed that one because the CI was failing but it seems that it was just hanging and we should have sent a message. We had a look at your warnings and we believe that this will work well. Don't hesitate to come back to us if this is not the case.

@enzbang enzbang closed this Oct 18, 2022
@simonjwright simonjwright deleted the aarch64-darwin branch October 18, 2022 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nikokrock Nikokrock Awaiting requested review from Nikokrock

Assignees
No one assigned
Labels
duplicate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simonjwright @CLAassistant @enzbang