Skip to content

260 Unicode support with PIC N notation #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 12, 2020
Merged

260 Unicode support with PIC N notation #261

merged 1 commit into from
Mar 12, 2020

Conversation

schaloner-kbc
Copy link
Contributor

  • Add support for PIC N(num) notation, where field size is num * 2
  • Adapted tests to include PIC N

Resolves #260

@schaloner-kbc
260 Unicode support with PIC N notation
989bf28 
- Add support for PIC N(num) notation, where field size is num * 2
- Adapted tests to include PIC N
@schaloner-kbc schaloner-kbc requested a review from yruslan as a code owner March 12, 2020 10:15
@yruslan yruslan requested a review from tr11 March 12, 2020 11:32
yruslan
yruslan approved these changes Mar 12, 2020
View reviewed changes
Copy link
Collaborator

@yruslan yruslan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. I like it!

@tr11, do you have some time to have a look as well?

@yruslan
Copy link
Collaborator

yruslan commented Mar 12, 2020

When this is merged we will add decoders to support UNCODE strings.

@yruslan yruslan merged commit a5263bc into AbsaOSS:master Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yruslan yruslan yruslan approved these changes

+1 more reviewer

@tr11 tr11 tr11 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unicode support with PIC N notation
3 participants
@schaloner-kbc @yruslan @tr11