This repository was archived by the owner on Jan 17, 2023. It is now read-only.
Modifies AFJSONObjectByRemovingKeysWithNullValues to remove NSArray null objects #4052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure about the CI failures – can anyone point me in the right direction? |
|
Seems reasonable. The CI failures were probably from outdated test certificates; testing locally. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a test case that causes
AFJSONObjectByRemovingKeysWithNullValuesto return a JSON object containingNSNulls in arrays, and added check againstNSNullbefore adding to the response array. Let me know if I can clarify anything. You can see a real-world test case here: https://github.com/artsy/eigen/pull/2423/files#diff-99f40649a0fc5dfc78a7014cefddddc5R104