Skip to content

chore: use github.token as default input #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

chore: use github.token as default input #112

wants to merge 2 commits into from

Conversation

fty4
Copy link

@fty4 fty4 commented Jun 23, 2023

Add github.token as default token input.

Currently if no token nor version is specified the action will return - as known - a warning:

Warning: Error while fetching latest Helm release: Error: [@octokit/auth-action] GITHUB_TOKEN variable is not set. It must be set on either env: or with:. See https://github.com/octokit/auth-action.js#createactionauth. Using default version v3.9.0

This can be resolved if the default token will automatically be specified.
With this change the workflow step to setup-helm can be one single line.

@fty4 fty4 requested a review from a team as a code owner June 23, 2023 06:27
@github-actions github-actions bot added the stale 90 days old label Jul 7, 2023
@github-actions
Copy link

This PR is idle because it has been open for 14 days with no activity.

@github-actions github-actions bot added idle Inactive for 14 days and removed stale 90 days old idle Inactive for 14 days labels Jul 21, 2023
@github-actions
Copy link

github-actions bot commented Aug 4, 2023

This PR is idle because it has been open for 14 days with no activity.

@github-actions github-actions bot added the idle Inactive for 14 days label Aug 4, 2023
@github-actions github-actions bot added stale 90 days old and removed idle Inactive for 14 days labels Aug 18, 2023
@github-actions
Copy link

github-actions bot commented Sep 1, 2023

This PR is idle because it has been open for 14 days with no activity.

@github-actions github-actions bot added the idle Inactive for 14 days label Sep 1, 2023
davidgamero
davidgamero previously approved these changes Sep 1, 2023
View reviewed changes
Copy link
Collaborator

@davidgamero davidgamero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions github-actions bot removed stale 90 days old idle Inactive for 14 days labels Sep 1, 2023
@github-actions github-actions bot added the stale 90 days old label Sep 15, 2023
@github-actions
Copy link

This PR is idle because it has been open for 14 days with no activity.

@github-actions github-actions bot added idle Inactive for 14 days and removed stale 90 days old idle Inactive for 14 days labels Sep 30, 2023
@github-actions github-actions bot added the stale 90 days old label Oct 14, 2023
@github-actions
Copy link

This PR is idle because it has been open for 14 days with no activity.

@github-actions github-actions bot added idle Inactive for 14 days and removed stale 90 days old idle Inactive for 14 days labels Oct 28, 2023
@fty4
Copy link
Author

fty4 commented Oct 31, 2023 •
edited
Loading

@davidgamero is there an intention to merge the PR? Could you suggest another reviewer?

@github-actions github-actions bot added the stale 90 days old label Nov 14, 2023
@github-actions GitHub Actions
Copy link

This PR is idle because it has been open for 14 days with no activity.

@github-actions github-actions bot added the idle Inactive for 14 days label Nov 28, 2023
@github-actions github-actions bot removed stale 90 days old idle Inactive for 14 days labels Nov 28, 2023
@github-actions github-actions bot added the stale 90 days old label Dec 12, 2023
@github-actions GitHub Actions
Copy link

This PR is idle because it has been open for 14 days with no activity.

@github-actions github-actions bot added idle Inactive for 14 days and removed stale 90 days old idle Inactive for 14 days labels Dec 26, 2023
@fty4 fty4 requested a review from davidgamero January 3, 2024 07:26
@github-actions github-actions bot added the stale 90 days old label Jan 17, 2024
@bonddim bonddim mentioned this pull request Jan 27, 2024
Merged
@github-actions GitHub Actions
Copy link

This PR is idle because it has been open for 14 days with no activity.

@github-actions github-actions bot added idle Inactive for 14 days and removed stale 90 days old idle Inactive for 14 days labels Jan 31, 2024
@fty4 fty4 deleted the chore/token-default branch February 16, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidgamero davidgamero Awaiting requested review from davidgamero

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fty4 @davidgamero