Skip to content

Chore/inspektor-gadget: Use Helm Go SDK #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 13, 2025
Merged

Chore/inspektor-gadget: Use Helm Go SDK #149

merged 1 commit into from
Aug 13, 2025

Conversation

mqasimsarfraz
Copy link
Member

@mqasimsarfraz mqasimsarfraz commented Aug 12, 2025 •
edited
Loading

As discussed in here #145 (comment) we should move IG handlers away from helm command so this change implements a minimal helm client to perform IG actions.

Testing Done:

→ which helm
→ helm
Command 'helm' not found, but can be installed with:
sudo snap install helm

and test logs here.

@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 128 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@f384351). Learn more about missing BASE report.
⚠️ Report is 55 commits behind head on main.

Files with missing lines Patch % Lines
internal/components/inspektorgadget/helm.go 0.00% 99 Missing ⚠️
internal/components/inspektorgadget/handlers.go 0.00% 29 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #149   +/-   ##
=======================================
  Coverage        ?   33.89%           
=======================================
  Files           ?       57           
  Lines           ?     5715           
  Branches        ?        0           
=======================================
  Hits            ?     1937           
  Misses          ?     3695           
  Partials        ?       83

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mqasimsarfraz mqasimsarfraz force-pushed the chore/helm-sdk branch 2 times, most recently from 17506e9 to 9ae88b7 Compare August 12, 2025 13:54
@mqasimsarfraz
Chore/inspektor-gadget: Use Helm Go SDK
21b583d 
Signed-off-by: Qasim Sarfraz <qasimsarfraz@microsoft.com>
feiskyer
feiskyer approved these changes Aug 13, 2025
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks refining this.

@feiskyer feiskyer merged commit a1b950b into Azure:main Aug 13, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mqasimsarfraz @codecov-commenter @feiskyer