Fix: validate all cli #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
now some tools could be not functional if related cli does not exist, so I am making this change. however, with the validations it will always require 'az', 'kubectl', 'helm', what if the user don't need to work with these tools? we need to discuss on this situation first before merging the PR. |
feiskyer
reviewed
Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The validator is missing several CLI tool validations. Here are the CLI tools being used by the system:
az - Already validated ✅
kubectl - Always required (core Kubernetes functionality) ❌ Missing validation
helm - Used by Inspektor Gadget component and optional additional tools ❌ Missing validation (update: IG will be changed to use go sdk)
cilium - Optional tool (when enabled via --additional-tools) ❌ Missing validation
This PR is to add validation for them.