-
Notifications
You must be signed in to change notification settings - Fork 15
docs: add labs for using aks-mcp with SK #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #125 +/- ##
=======================================
Coverage ? 31.73%
=======================================
Files ? 53
Lines ? 5193
Branches ? 0
=======================================
Hits ? 1648
Misses ? 3470
Partials ? 75 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
… multiple transport protocols
…uctions and prerequisites
internal/tools/handler.go
Outdated
if err != nil { | ||
log.Printf(" ERROR: %v", err) | ||
} else if len(result) > 500 { | ||
log.Printf(" Result: %d bytes (truncated): %.500s...", len(result), result) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also add tool name in the result log?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done in 6e1898e
docs/labs/README.md
Outdated
@@ -0,0 +1,193 @@ | |||
# AKS MCP Transport Testing Guide |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: calling Lab instead of test/testing in this document (it is a user-facing lab instead of a test of this project)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done in f44ecfe
…ology and clarify lab exercises with AKS-MCP server
@microsoft-github-policy-service agree company="Microsoft" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pull request introduces several changes to enhance the AKS-MCP lab documentation, improve logging functionality, and add verbose logging support to the configuration and tools. The most important changes include updates to the documentation and examples, the addition of verbose logging capabilities, and the creation of a comprehensive lab client script for testing AKS-MCP integration.
Documentation and Example Enhancements:
docs/labs/README.md
to explain the AKS-MCP transport protocols, prerequisites, setup, and lab exercises. It includes step-by-step instructions for using STDIO, SSE, and Streamable HTTP transports, as well as troubleshooting tips and performance recommendations..env
file indocs/labs/.env.example
with configuration placeholders for Azure OpenAI and AKS cluster details..gitignore
indocs/labs
to exclude environment files, Jupyter checkpoints, Python artifacts, IDE configurations, and temporary files.Logging Enhancements:
Verbose
flag to theConfigData
struct ininternal/config/config.go
and updated theParseFlags
function to enable verbose logging via the-v
flag. [1] [2]logToolCall
andlogToolResult
helper functions ininternal/tools/handler.go
to log tool calls and results when verbose logging is enabled. These functions format logs for better readability and include error handling. [1] [2]Lab Client Script:
test_aks_mcp.py
indocs/labs
to test AKS-MCP integration with Semantic Kernel. The script supports multiple transport protocols (STDIO, SSE, Streamable HTTP) and includes comprehensive scenarios to validate AKS-MCP capabilities. It also provides detailed output and troubleshooting guidance.