-
Notifications
You must be signed in to change notification settings - Fork 15
feat: enhance AKS-MCP with Kubernetes placement operations #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… documentation - Added support for Kubernetes ClusterResourcePlacement operations in the fleet command executor. - Updated README to reflect new capabilities, including managing Azure Fleet and Kubernetes resources. - Enhanced command descriptions and examples for clarity. - Introduced new commands for placement management: create, list, show, and delete. - Improved error handling and validation for placement operations.
…s placement operations - Removed unnecessary stdout logging during panic recovery to reduce pollution. - Introduced a new `cleanResult` function to sanitize results for MCP compatibility. - Streamlined the creation of resource selectors in the `CreatePlacement` method. - Updated `GetPlacement` and `ListPlacements` methods to return results in JSON format for better integration.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #91 +/- ##
=======================================
Coverage ? 30.78%
=======================================
Files ? 47
Lines ? 4194
Branches ? 0
=======================================
Hits ? 1291
Misses ? 2875
Partials ? 28 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…be consistent with CRD name
…lacement operations
…erations and improve error messages - Changed parameter type in test cases from `map[string]interface{}` to `map[string]any`. - Updated error messages to specify when placement operations are not initialized. - Ensured all relevant tests reflect the new error handling for uninitialized operations.
gossion
approved these changes
Jul 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for managing Kubernetes ClusterResourcePlacement (CRP) operations within Azure Kubernetes Service (AKS) Fleet management tools. It includes updates to documentation, command-line tools, and backend logic to enable CRP operations such as create, list, show, and delete. The changes also enhance the Fleet Executor to handle Kubernetes-specific operations and improve usability by adding new commands like
get-credentials
for fleets.Demo: https://claude.ai/share/51ac03ff-5c3b-4f4b-bb53-c00c91cb1011
Documentation Updates:
README.md
to include Azure Fleet operations and CRP-related examples, such as creating placements and listing fleet members. [1] [2]get-credentials
command inprompts/azure-fleet-tools.md
. [1] [2] [3]Command-Line Tool Enhancements:
list
,show
,get
,create
,delete
) and theget-credentials
command to the Fleet tool registry (internal/components/fleet/registry.go
).Backend Logic:
FleetExecutor
to route CRP operations to Kubernetes APIs, initialize Kubernetes clients, and handle CRP-specific logic. [1] [2]kubectl
. [1] [2]Codebase Improvements:
These changes collectively enable seamless integration of Kubernetes CRP management into the existing Azure Fleet tools, providing users with enhanced capabilities for multi-cluster scenarios.