Feat: support getting control plane logs #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feiskyer
reviewed
Jul 16, 2025
There was a problem hiding this comment.
Detailed Code Suggestions
1. Extract hard-coded values to constants (line 194)
const (
MaxLogRetentionDays = 7
MaxQueryRangeDuration = 24 * time.Hour
DefaultMaxRecords = 100
MaxAllowedRecords = 1000
)2. Extract resource ID construction utility (line 27)
func buildClusterResourceID(subscriptionID, resourceGroup, clusterName string) string {
return fmt.Sprintf("/subscriptions/%s/resourceGroups/%s/providers/Microsoft.ContainerService/managedClusters/%s",
subscriptionID, resourceGroup, clusterName)
}3. Improve log level mapping (line 292)
var logLevelPrefixes = map[string]string{
"info": "I",
"warning": "W",
"error": "E",
}
if prefix, exists := logLevelPrefixes[strings.ToLower(logLevel)]; exists {
baseQuery += fmt.Sprintf(" | where log_s startswith '%s'", prefix)
}4. Add more context to error messages (line 42)
return "", fmt.Errorf("failed to get diagnostic settings for cluster %s in resource group %s: %w", clusterName, resourceGroup, err)5. Consider splitting large file for better organization
The 400-line handler file could benefit from being split:
internal/components/monitor/
├── diagnostics.go (main handlers)
├── validation.go (parameter validation)
├── kql.go (query building)
└── workspace.go (workspace GUID extraction)
fixed 1,2,3,4. skipping 5 for this time (I would change it later) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces functionality for managing and querying AKS control plane diagnostics and logs, along with enhancements to command validation for security. The changes include new handler functions, tools registration, and specialized validation for KQL queries.
AKS Control Plane Diagnostics and Logs Management:
HandleControlPlaneDiagnosticSettingsandHandleControlPlaneLogsfunctions to manage diagnostic settings and query control plane logs with validation and safety constraints. (internal/components/monitor/diagnostics_handlers.go, internal/components/monitor/diagnostics_handlers.goR1-R400)aks_control_plane_diagnostic_settings) and querying control plane logs (aks_control_plane_logs) with detailed parameter validation and descriptions. (internal/components/monitor/registry.go, internal/components/monitor/registry.goR101-R155)internal/server/server.go, [1] [2]Security Enhancements:
az monitor log-analytics querycommands to ensure KQL queries are properly quoted and other command parts are free of dangerous patterns. (internal/security/validator.go, [1] [2]