Add rfc1123 datetime #485
Merged
Add rfc1123 datetime #485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kairu-ms
reviewed
Jun 4, 2025
kairu-ms
reviewed
Jun 4, 2025
kairu-ms
reviewed
Jun 5, 2025
| diff = {} | ||
|
|
||
| if level >= CMDDiffLevelEnum.BreakingChange: | ||
| if self.protocol and self.protocol == old.protocol and self.protocol != old.protocol: |
There was a problem hiding this comment.
For checking whether two cmds can be merged. (But seems now will always be overwritten by following part)
kairu-ms
reviewed
Jun 5, 2025
Co-authored-by: kai ru <69238381+kairu-ms@users.noreply.github.com>
kairu-ms
approved these changes
Jun 5, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, codegen already supports
date-timeformat, its corresponding arg in cli aaz isAAZDateTimeArg, withAAZDateTimeFormatusing a default protocoliso.For rfc-1123, the difference in cli core is the format protocol to be
rfcswagger example: https://github.com/Azure/azure-rest-api-specs/blob/bd98c68b0a0b91e8479f7eb121d488f8f78d4d86/specification/storage/data-plane/Microsoft.BlobStorage/stable/2025-07-05/blob.json#L7148
date-timeformat string:date-time-rfc1123format string: