Ignore clientRequestIdName in header param and add uuid format parsing #467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kairu-ms
reviewed
Mar 11, 2025
| @@ -182,7 +182,8 @@ def _generate_command_name(cls, path_item, resource, method, output): | |||
| # f"Command Name For Get set to 'list' by nexLink: {resource.path} :" | |||
| # f" {path_item.get.operation_id} : {path_item.traces}" | |||
| # ) | |||
| elif sub_url_path in resource.resource_provider.get_resource_map(): | |||
| elif isinstance(resource, Resource) and sub_url_path in resource.resource_provider.get_resource_map(): | |||
There was a problem hiding this comment.
why check resource as Resource type can avoid the issue. Why not directly check the resource.resource_provider type?
There was a problem hiding this comment.
typespec-aaz emitter from frontend will return CMDResource directly which does not have resource_provider and will break here, while swagger api would have a valid Resource and its corresponding resource_provider.
We can check if hasattr(resource, 'resource_provider') directly too, still the root diff comes from CMDResource from typespec-aaz and Resource from swagger translator.
kairu-ms
previously approved these changes
Mar 14, 2025
kairu-ms
approved these changes
Mar 14, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.