Skip to content

Conversation

kairu-ms
Copy link
Collaborator

@kairu-ms kairu-ms commented Feb 24, 2025

image

@kairu-ms kairu-ms requested a review from Copilot February 24, 2025 06:30
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 7 out of 11 changed files in this pull request and generated no comments.

Files not reviewed (4)
  • src/aaz_dev/command/model/configuration/init.py: Evaluated as low risk
  • src/aaz_dev/swagger/model/schema/response.py: Evaluated as low risk
  • src/aaz_dev/command/model/configuration/_arg_builder.py: Evaluated as low risk
  • src/aaz_dev/swagger/model/schema/schema.py: Evaluated as low risk
Comments suppressed due to low confidence (2)

src/aaz_dev/command/model/configuration/_arg.py:686

  • The deprecation of the 'any_type' property should be clearly documented and managed to avoid confusion.
if self.any_type and not self.item:

src/aaz_dev/command/model/configuration/_schema.py:820

  • The comment should be rephrased for clarity. Suggested: '# WARNING: This property will be deprecated. CMDAnyTypeSchemaBase should be used directly as the item value.'
# WARNING: this property will be deprecated as CMDAnyTypeSchemaBase are supported, should directly use CMDAnyTypeSchemaBase as item value

@kairu-ms kairu-ms merged commit aef5fc9 into Azure:dev Feb 24, 2025
3 checks passed
@kairu-ms kairu-ms mentioned this pull request Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants