-
Notifications
You must be signed in to change notification settings - Fork 59
Provide short message for cmd if not exists #453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kairu-ms
reviewed
Feb 21, 2025
src/aaz_dev/command/api/editor.py
Outdated
Comment on lines
628
to
641
# provide default short summary | ||
for node in manager.iter_command_tree_nodes(): | ||
if not node.help: | ||
node.help = CMDHelp() | ||
if not node.help.short: | ||
node.help.short = f"Manage {node.names[-1]}" | ||
|
||
for leaf in manager.iter_command_tree_leaves(): | ||
if not leaf.help: | ||
leaf.help = CMDHelp() | ||
if not leaf.help.short: | ||
n = leaf.names[-1] | ||
n = n[0].upper() + n[1:] | ||
leaf.help.short = f"{n} {leaf.names[-2]}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't implement code in the api level. Please implement it in related code of command generation.
6140ea0
to
05679e8
Compare
kairu-ms
reviewed
Feb 27, 2025
kairu-ms
reviewed
Feb 27, 2025
e6c2b8e
to
1d79cef
Compare
kairu-ms
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.