Skip to content

New options to exclude resources to be exported: --exclude-[terraform|azure]-resource(-file) #620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 1, 2025
Merged

New options to exclude resources to be exported: --exclude-[terraform|azure]-resource(-file) #620

merged 3 commits into from
May 1, 2025

Conversation

magodo
Copy link
Collaborator

@magodo magodo commented Apr 30, 2025

Fix #618

@magodo magodo requested review from ms-henglu and gerrytan and removed request for gerrytan and ms-henglu April 30, 2025 06:31
@magodo magodo added the enhancement New feature or request label Apr 30, 2025
gerrytan
gerrytan requested changes Apr 30, 2025
View reviewed changes
Copy link
Member

@gerrytan gerrytan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed on DM: place the resource filtering logic into a single function so it can be easily refactored and unit tested.

The overall changes look good otherwise, nice!

@magodo magodo merged commit d015d85 into Azure:main May 1, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gerrytan gerrytan gerrytan approved these changes

@ms-henglu ms-henglu Awaiting requested review from ms-henglu

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

need command option to skip resource type(s)
2 participants
@magodo @gerrytan