Add AllowTapRangeSelection for Calendar #19367
Merged
+241
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can test this PR using the following package version. |
|
API diff for review: namespace Avalonia.Controls
{
public class Calendar : TemplatedControl
{
+ public static readonly StyledProperty<bool> AllowTapRangeSelectionProperty;
+ public bool AllowTapRangeSelection { get; set; }
}
} |
|
The API is approved, but we want it |
|
@drasticactions The |
|
You can test this PR using the following package version. |
MrJul
pushed a commit
that referenced
this pull request
Aug 15, 2025
* Add AllowTapRangeSelection for Calendar * Fix spacing * Let it be true... * Update CalendarTests.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Adds a new API to Calendar to allow tapping twice to select a range of dates.
What is the current behavior?
Date selection ranges are done using keyboard shortcuts, which does not work on mobile.
What is the updated/expected behavior with this PR?
This PR introduces a new
AllowTapRangeSelectionfeature, enabling users to tap once to select an initial date and tap again to choose the second. It only works forSingleRangemode. If you haveMultipleRangeselected, it will work for the first range, then reset for the second.I've added the boolean to preserve the existing keyboard functions for users who expect a new start date when clicking, ensuring the original functions remain intact. This is intended as a stopgap measure while we research different ways of handling more advance features in the future.