Fix random NRE inside Compositor.CommitCore() callback.
#19173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can test this PR using the following package version. |
|
|
@cla-avalonia agree |
kekekeks
approved these changes
Jul 3, 2025
MrJul
pushed a commit
that referenced
this pull request
Aug 5, 2025
* Prevent ContinueWith from scheduling some of rendering callbacks into UI thread. (#19170 fix) * Add _pendingBatch null check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Makes all
Task.ContinueWithcalls in rendering-related code to useTaskScheduler.Default.What is the current behavior?
When
Compositor.CommitCore()is called indirectly from task (for example viaDispatcher.InvokeorDispatcher.PushFramemethods) started with TaskScheduler, that scheduler will be used byContinueWithto continuation scheduling.See #19710 for reproducible sample
What is the updated/expected behavior with this PR?
All continuations in rendering-related code now use
TaskScheduler.Default.Fixed issues
Fixes #19710