-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Fix for #19035 On macOS, the SuggestedStartLocation is not set if the FileTypeChoices is not null #19036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for #19035 On macOS, the SuggestedStartLocation is not set if the FileTypeChoices is not null #19036
Conversation
…set if the FileTypeChoices Is not null
And this should be also backported to Avalonia 11.2.x :) |
Please read the following Contributor License Agreement (CLA). If you agree with the CLA, please reply with the following:
Contributor License AgreementContribution License AgreementThis Contribution License Agreement ( “Agreement” ) is agreed to by the party signing below ( “You” ), 1. Definitions. “Code” means the computer software code, whether in human-readable or machine-executable form, “Project” means any of the projects owned or managed by AvaloniaUI OÜ and offered under a license “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any “Submission” means the Code and any other copyrightable material Submitted by You, including any 2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any 3. Originality of Work. You represent that each of Your Submissions is entirely Your 4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else 5. Licenses. a. Copyright License. You grant AvaloniaUI OÜ, and those who receive the Submission directly b. Patent License. You grant AvaloniaUI OÜ, and those who receive the Submission directly or c. Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement. 6. Representations and Warranties. You represent that You are legally entitled to grant the above 7. Notice to AvaloniaUI OÜ. You agree to notify AvaloniaUI OÜ in writing of any facts or 8. Information about Submissions. You agree that contributions to Projects and information about 9. Governing Law/Jurisdiction. This Agreement is governed by the laws of the Republic of Estonia, and 10. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and AvaloniaUI OÜ dedicates this Contribution License Agreement to the public domain according to the Creative Commons CC0 1. |
@cla-avalonia agree |
You can test this PR using the following package version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice find.
It would take hours of debugging to find out.
Things like this must have comments explaining why the sequence is important in source code. So many fixes like this get merged without commenting in code. The next refactoring that comes along there is a high risk to break things again. Very few will follow the PR history and descriptions. I think the core team needs to ask for more comments in source code (for this type of PR) so this knowledge isn't lost. It happens a lot. |
… FileTypeChoices Is not null (#19036)
What does the pull request do?
fix the issue #19035 :
The SuggestedStartLocation is not used by the StorageProvider window on macOS if the FileTypeChoices is set.
The SetAccessoryView in AvaloniaNative reset the directoryURL.
What is the current behavior?
In AvaloniaNative, the directoryURL is set before the SetAccessoryView. The SetAccessoryView is messing with directoryURL and fallback to the defaultFolder instead of the SuggestedStartLocation.
What is the updated/expected behavior with this PR?
In AvaloniaNative, the AccessoryView is set before the DirectoryURL, keeping the SuggestedStartLocation
How was the solution implemented (if it's not obvious)?
the set of directoryURL is done after the SetAccessoryView instead of before.
Checklist
Breaking changes
none
Obsoletions / Deprecations
Fixed issues
Fixes #19035