android: better api level detection for display edge to edge and ignore system bar color changes if on api level 35 #19034
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re system bar color changes if on api level 35
|
You can test this PR using the following package version. |
|
You can test this PR using the following package version. |
maxkatz6
approved these changes
Jun 13, 2025
This was referenced Jun 17, 2025
MrJul
pushed a commit
that referenced
this pull request
Jun 24, 2025
…re system bar color changes if on api level 35 (#19034) * android: better api level detection for display edge to edge and ignore system bar color changes if on api level 35 * allow fully transparent nav bars when display edge to edge is forced
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Follow up for #18844 .
This time system bar theme is now ignored for android 15 when targeting api level 35. This fixes an issue where you app is in light mode, all theme colors are light, but because on the new nav bar filter that android applies to darken the nav bar over the activity, setting the system bar to light theme appearance, thus giving it a dark foreground, will cause the nav bar buttons to disappear.
Now, android will always use a light foreground color if nav bar is visible, or will detect and use the requested DayNight config of the app when system bars are hidden.
What is the current behavior?
What is the updated/expected behavior with this PR?
How was the solution implemented (if it's not obvious)?
Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues