Add FontSize property validation #18198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrJul
approved these changes
Feb 14, 2025
|
You can test this PR using the following package version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small improvement with more user-friendly validation.
What is the current behavior?
Before this PR it was possible to break the layout by passing invalid property value, by passing negative font size.
It is somewhat important, since user can now handle unhandled dispatcher exception and continue app running, with broken layout.
What is the updated/expected behavior with this PR?
With this PR, FontSize property will validate input values itself, and throw validation exception, discarding any invalid input from being actually set.
It's also consistent with WPF behavior. Although there is a difference in which values are allowed, as WPF only allows range
0.003...16000. But Avalonia doesn't enforce these limitations.