Upgrade integration tests to a common standard #349

gudmdharalds · 2023-02-17T15:53:53Z

This pull request partially updates a number of integration tests so they comply with a common standard, see #244.

This change is needed so that tests will work after #350 is merged, as otherwise they will fail due to duplication of a declared function. Specifically, the @runTestsInSeparateProcesses and @preserveGlobalState settings are needed and to move the require_once usages to the setUp() functions.

TODO:

Applying common standard across a number of integration tests.
[N/A] Add to, or update, Scan run detail report as applicable
Check status of automated tests
[N/A] Ensure PHPDoc comments are up to date for functions added or altered
Changelog entry (for VIP) [ Changelog for version 1.3.4 #333 ]

…attic/vip-go-ci into update/intgr-tests-common-standard

wpcomvip-vipgoci-bot

Code analysis identified issues

VIP Code Analysis Bot has identified potential problems in this pull request during automated scanning. We recommend reviewing the issues noted and that they are resolved.

phpcs scanning turned up:

🚫 68 errors

⚠️ 32 warnings

This bot provides automated PHP linting and PHPCS scanning. For more information about the bot and available customizations, see our documentation.

Scan run detail

Software versions vip-go-ci version: `1.3.3` PHP runtime version for vip-go-ci: `8.1.16` PHP runtime for linting: PHP 8.1: `8.1.16` PHP runtime version for PHPCS: `7.4.33` PHPCS version: `3.7.1` PHP runtime version for SVG scanner: `7.4.33` Options file (`.vipgoci_options`) Options file enabled: `true` Configurable options: `skip-execution` `skip-draft-prs` `lint-modified-files-only` `phpcs` `phpcs-severity` `phpcs-sniffs-include` `phpcs-sniffs-exclude` `report-no-issues-found` `review-comments-sort` `review-comments-include-severity` `post-generic-pr-support-comments` `review-comments-sort` `scan-details-msg-include` `svg-checks` `autoapprove` `autoapprove-php-nonfunctional-changes` Options altered: `phpcs-severity`set to`1` `phpcs-sniffs-include`set to`Generic.PHP.DisallowShortOpenTag, Squiz.PHP.CommentedOutCode` `phpcs-sniffs-exclude`set to`WordPress.Security.EscapeOutput, WordPress.PHP.DevelopmentFunctions, WordPress.WP.AlternativeFunctions, WordPress.PHP.DiscouragedPHPFunctions, WordPress.Files.FileName, Squiz.Commenting.FileComment, Generic.PHP.Syntax` `skip-draft-prs`set to	PHP lint options PHP lint files enabled: `true` Lint modified files only: `true` Lint files with file extensions: `php` Directories not PHP linted: None SVG configuration SVG scanning enabled: `true` Scan added/modified files with file extensions: `svg` Auto-approval configuration Auto-approvals enabled: `true` Non-functional changes auto-approved: `true` Files with file extensions to consider for non-functional change auto-approval: `php` Auto-approved file-types: `css` `csv` `eot` `gif` `gz` `ico` `ini` `jpeg` `jpg` `json` `less` `map` `md` `mdown` `mo` `mp4` `otf` `pcss` `pdf` `po` `pot` `png` `sass` `scss` `styl` `ttf` `txt` `woff` `woff2` `yml`	PHPCS configuration PHPCS scanning enabled: `true` PHPCS severity level: `1` Standard(s) used: `PHPCompatibility` `PHPCompatibilityParagonieRandomCompat` `PHPCompatibilityParagonieSodiumCompat` `VariableAnalysis` `WordPress` Runtime set: `testVersion 8.1-` Scan added/modified files with file extensions: `php` `js` `twig` Custom sniffs included: `Generic.PHP.DisallowShortOpenTag` `Squiz.PHP.CommentedOutCode` Custom sniffs excluded: `WordPress.Security.EscapeOutput` `WordPress.PHP.DevelopmentFunctions` `WordPress.WP.AlternativeFunctions` `WordPress.PHP.DiscouragedPHPFunctions` `WordPress.Files.FileName` `Squiz.Commenting.FileComment` `Generic.PHP.Syntax` Directories not PHPCS scanned: None WPScan API configuration WPScan API scanning enabled: `false`

Posting will continue in further review(s)

tests/integration/ResultsFilterCommentsToMaxTest.php

wpcomvip-vipgoci-bot

Previous scan continued.

tests/integration/ResultsFilterCommentsToMaxTest.php

wpcomvip-vipgoci-bot

Previous scan continued.

tests/integration/ResultsFilterCommentsToMaxTest.php

wpcomvip-vipgoci-bot

Previous scan continued.

tests/integration/ResultsFilterCommentsToMaxTest.php

wpcomvip-vipgoci-bot

Code analysis identified issues

VIP Code Analysis Bot has identified potential problems in this pull request during automated scanning. We recommend reviewing the issues noted and that they are resolved.

phpcs scanning turned up:

🚫 20 errors

⚠️ 8 warnings

This bot provides automated PHP linting and PHPCS scanning. For more information about the bot and available customizations, see our documentation.

Scan run detail

Software versions vip-go-ci version: `1.3.3` PHP runtime version for vip-go-ci: `8.1.16` PHP runtime for linting: PHP 8.1: `8.1.16` PHP runtime version for PHPCS: `7.4.33` PHPCS version: `3.7.1` PHP runtime version for SVG scanner: `7.4.33` Options file (`.vipgoci_options`) Options file enabled: `true` Configurable options: `skip-execution` `skip-draft-prs` `lint-modified-files-only` `phpcs` `phpcs-severity` `phpcs-sniffs-include` `phpcs-sniffs-exclude` `report-no-issues-found` `review-comments-sort` `review-comments-include-severity` `post-generic-pr-support-comments` `review-comments-sort` `scan-details-msg-include` `svg-checks` `autoapprove` `autoapprove-php-nonfunctional-changes` Options altered: `phpcs-severity`set to`1` `phpcs-sniffs-include`set to`Generic.PHP.DisallowShortOpenTag, Squiz.PHP.CommentedOutCode` `phpcs-sniffs-exclude`set to`WordPress.Security.EscapeOutput, WordPress.PHP.DevelopmentFunctions, WordPress.WP.AlternativeFunctions, WordPress.PHP.DiscouragedPHPFunctions, WordPress.Files.FileName, Squiz.Commenting.FileComment, Generic.PHP.Syntax` `skip-draft-prs`set to	PHP lint options PHP lint files enabled: `true` Lint modified files only: `true` Lint files with file extensions: `php` Directories not PHP linted: None SVG configuration SVG scanning enabled: `true` Scan added/modified files with file extensions: `svg` Auto-approval configuration Auto-approvals enabled: `true` Non-functional changes auto-approved: `true` Files with file extensions to consider for non-functional change auto-approval: `php` Auto-approved file-types: `css` `csv` `eot` `gif` `gz` `ico` `ini` `jpeg` `jpg` `json` `less` `map` `md` `mdown` `mo` `mp4` `otf` `pcss` `pdf` `po` `pot` `png` `sass` `scss` `styl` `ttf` `txt` `woff` `woff2` `yml`	PHPCS configuration PHPCS scanning enabled: `true` PHPCS severity level: `1` Standard(s) used: `PHPCompatibility` `PHPCompatibilityParagonieRandomCompat` `PHPCompatibilityParagonieSodiumCompat` `VariableAnalysis` `WordPress` Runtime set: `testVersion 8.1-` Scan added/modified files with file extensions: `php` `js` `twig` Custom sniffs included: `Generic.PHP.DisallowShortOpenTag` `Squiz.PHP.CommentedOutCode` Custom sniffs excluded: `WordPress.Security.EscapeOutput` `WordPress.PHP.DevelopmentFunctions` `WordPress.WP.AlternativeFunctions` `WordPress.PHP.DiscouragedPHPFunctions` `WordPress.Files.FileName` `Squiz.Commenting.FileComment` `Generic.PHP.Syntax` Directories not PHPCS scanned: None WPScan API configuration WPScan API scanning enabled: `false`

Posting will continue in further review(s)

tests/integration/ResultsFilterCommentsToMaxTest.php

wpcomvip-vipgoci-bot

Previous scan continued.

tests/integration/ResultsFilterCommentsToMaxTest.php

wpcomvip-vipgoci-bot

Code analysis identified issues

VIP Code Analysis Bot has identified potential problems in this pull request during automated scanning. We recommend reviewing the issues noted and that they are resolved.

phpcs scanning turned up:

🚫 9 errors

⚠️ 2 warnings

This bot provides automated PHP linting and PHPCS scanning. For more information about the bot and available customizations, see our documentation.

Scan run detail

Software versions vip-go-ci version: `1.3.3` PHP runtime version for vip-go-ci: `8.1.16` PHP runtime for linting: PHP 8.1: `8.1.16` PHP runtime version for PHPCS: `7.4.33` PHPCS version: `3.7.1` PHP runtime version for SVG scanner: `7.4.33` Options file (`.vipgoci_options`) Options file enabled: `true` Configurable options: `skip-execution` `skip-draft-prs` `lint-modified-files-only` `phpcs` `phpcs-severity` `phpcs-sniffs-include` `phpcs-sniffs-exclude` `report-no-issues-found` `review-comments-sort` `review-comments-include-severity` `post-generic-pr-support-comments` `review-comments-sort` `scan-details-msg-include` `svg-checks` `autoapprove` `autoapprove-php-nonfunctional-changes` Options altered: `phpcs-severity`set to`1` `phpcs-sniffs-include`set to`Generic.PHP.DisallowShortOpenTag, Squiz.PHP.CommentedOutCode` `phpcs-sniffs-exclude`set to`WordPress.Security.EscapeOutput, WordPress.PHP.DevelopmentFunctions, WordPress.WP.AlternativeFunctions, WordPress.PHP.DiscouragedPHPFunctions, WordPress.Files.FileName, Squiz.Commenting.FileComment, Generic.PHP.Syntax` `skip-draft-prs`set to	PHP lint options PHP lint files enabled: `true` Lint modified files only: `true` Lint files with file extensions: `php` Directories not PHP linted: None SVG configuration SVG scanning enabled: `true` Scan added/modified files with file extensions: `svg` Auto-approval configuration Auto-approvals enabled: `true` Non-functional changes auto-approved: `true` Files with file extensions to consider for non-functional change auto-approval: `php` Auto-approved file-types: `css` `csv` `eot` `gif` `gz` `ico` `ini` `jpeg` `jpg` `json` `less` `map` `md` `mdown` `mo` `mp4` `otf` `pcss` `pdf` `po` `pot` `png` `sass` `scss` `styl` `ttf` `txt` `woff` `woff2` `yml`	PHPCS configuration PHPCS scanning enabled: `true` PHPCS severity level: `1` Standard(s) used: `PHPCompatibility` `PHPCompatibilityParagonieRandomCompat` `PHPCompatibilityParagonieSodiumCompat` `VariableAnalysis` `WordPress` Runtime set: `testVersion 8.1-` Scan added/modified files with file extensions: `php` `js` `twig` Custom sniffs included: `Generic.PHP.DisallowShortOpenTag` `Squiz.PHP.CommentedOutCode` Custom sniffs excluded: `WordPress.Security.EscapeOutput` `WordPress.PHP.DevelopmentFunctions` `WordPress.WP.AlternativeFunctions` `WordPress.PHP.DiscouragedPHPFunctions` `WordPress.Files.FileName` `Squiz.Commenting.FileComment` `Generic.PHP.Syntax` Directories not PHPCS scanned: None WPScan API configuration WPScan API scanning enabled: `false`

tests/integration/ResultsFilterCommentsToMaxTest.php

Dismissing review as all inline comments are obsolete by now

wpcomvip-vipgoci-bot · 2023-02-17T19:51:59Z

Scanning latest commit did not yield any new issues. Please have a look at older feedback still existing (commit-ID: 3ffacec)

This bot provides automated PHP linting and PHPCS scanning. For more information about the bot and available customizations, see our documentation.

Scan run detail

Software versions vip-go-ci version: `1.3.3` PHP runtime version for vip-go-ci: `8.1.16` PHP runtime for linting: PHP 8.1: `8.1.16` PHP runtime version for PHPCS: `7.4.33` PHPCS version: `3.7.1` PHP runtime version for SVG scanner: `7.4.33` Options file (`.vipgoci_options`) Options file enabled: `true` Configurable options: `skip-execution` `skip-draft-prs` `lint-modified-files-only` `phpcs` `phpcs-severity` `phpcs-sniffs-include` `phpcs-sniffs-exclude` `report-no-issues-found` `review-comments-sort` `review-comments-include-severity` `post-generic-pr-support-comments` `review-comments-sort` `scan-details-msg-include` `svg-checks` `autoapprove` `autoapprove-php-nonfunctional-changes` Options altered: `phpcs-severity`set to`1` `phpcs-sniffs-include`set to`Generic.PHP.DisallowShortOpenTag, Squiz.PHP.CommentedOutCode` `phpcs-sniffs-exclude`set to`WordPress.Security.EscapeOutput, WordPress.PHP.DevelopmentFunctions, WordPress.WP.AlternativeFunctions, WordPress.PHP.DiscouragedPHPFunctions, WordPress.Files.FileName, Squiz.Commenting.FileComment, Generic.PHP.Syntax` `skip-draft-prs`set to	PHP lint options PHP lint files enabled: `true` Lint modified files only: `true` Lint files with file extensions: `php` Directories not PHP linted: None SVG configuration SVG scanning enabled: `true` Scan added/modified files with file extensions: `svg` Auto-approval configuration Auto-approvals enabled: `true` Non-functional changes auto-approved: `true` Files with file extensions to consider for non-functional change auto-approval: `php` Auto-approved file-types: `css` `csv` `eot` `gif` `gz` `ico` `ini` `jpeg` `jpg` `json` `less` `map` `md` `mdown` `mo` `mp4` `otf` `pcss` `pdf` `po` `pot` `png` `sass` `scss` `styl` `ttf` `txt` `woff` `woff2` `yml`	PHPCS configuration PHPCS scanning enabled: `true` PHPCS severity level: `1` Standard(s) used: `PHPCompatibility` `PHPCompatibilityParagonieRandomCompat` `PHPCompatibilityParagonieSodiumCompat` `VariableAnalysis` `WordPress` Runtime set: `testVersion 8.1-` Scan added/modified files with file extensions: `php` `js` `twig` Custom sniffs included: `Generic.PHP.DisallowShortOpenTag` `Squiz.PHP.CommentedOutCode` Custom sniffs excluded: `WordPress.Security.EscapeOutput` `WordPress.PHP.DevelopmentFunctions` `WordPress.WP.AlternativeFunctions` `WordPress.PHP.DiscouragedPHPFunctions` `WordPress.Files.FileName` `Squiz.Commenting.FileComment` `Generic.PHP.Syntax` Directories not PHPCS scanned: None WPScan API configuration WPScan API scanning enabled: `false`

gdh added 30 commits February 16, 2023 17:58

PHP 8.2 compatibility update

d1bc0fa

Apply common standard

3d48af4

Apply common standard

8ca8f4f

Apply common standard

60d2aa3

Apply common standard

dc1b6e1

Apply common standard

63181a6

Apply common standard

4ff14b9

Apply common standard

0b04606

Apply common standard

3b8cd90

Apply common standard

e622687

Apply common standard

d8a1d29

Apply common standard

b0710b4

Apply common standard

004e1c3

Apply common standard

e63f6ae

Apply common standard

d735bcb

Apply common standard

9514e5d

Apply common standard

81d4409

Apply common standard

39020c6

Apply common standard

1ca6479

Apply common standard

f87ed15

Apply common standard

9b1a1a5

Apply common standard

7573b49

Apply common standard

32e003b

Apply common standard

cddd18d

Apply common standard

042fa2e

Apply common standard

886cd2e

Apply common standard

856b53e

Update to common standard

1ca6cce

Apply common standard

4fceb1b

Apply common standard

681cafc

gdh and others added 6 commits February 17, 2023 18:50

Enforce integer type

9b20cf9

Process isolation by default

e680506

Enforce integer type

a4768a4

Merge branch 'trunk' into update/intgr-tests-common-standard

853b4fc

Fixing require_once usage

285615b

Merge branch 'update/intgr-tests-common-standard' of github.com:Autom…

0d33f6e

…attic/vip-go-ci into update/intgr-tests-common-standard

wpcomvip-vipgoci-bot previously requested changes Feb 17, 2023

View reviewed changes

gdh added 2 commits February 17, 2023 19:29

Fixing comment

3e13591

Fixing comment

781214f

wpcomvip-vipgoci-bot previously requested changes Feb 17, 2023

View reviewed changes

gdh added 2 commits February 17, 2023 19:37

Adding code back in

ebb567a

Adding code back in

a64f2ea

wpcomvip-vipgoci-bot previously requested changes Feb 17, 2023

View reviewed changes

gdh added 2 commits February 17, 2023 19:44

Apply WP CS

c94df44

Apply WP CS

3ffacec

gudmdharalds merged commit 0d54008 into trunk Feb 17, 2023

gudmdharalds deleted the update/intgr-tests-common-standard branch February 17, 2023 19:53

gudmdharalds added the [Pri] Normal label May 12, 2023

Upgrade integration tests to a common standard #349

Upgrade integration tests to a common standard #349

Uh oh!

Conversation

gudmdharalds commented Feb 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpcomvip-vipgoci-bot left a comment

Choose a reason for hiding this comment

Code analysis identified issues

Software versions

Options file (.vipgoci_options)

PHP lint options

SVG configuration

Auto-approval configuration

PHPCS configuration

WPScan API configuration

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wpcomvip-vipgoci-bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wpcomvip-vipgoci-bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wpcomvip-vipgoci-bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wpcomvip-vipgoci-bot left a comment

Choose a reason for hiding this comment

Code analysis identified issues

Software versions

Options file (.vipgoci_options)

PHP lint options

SVG configuration

Auto-approval configuration

PHPCS configuration

WPScan API configuration

Uh oh!

Uh oh!

Uh oh!

gudmdharalds commented Feb 17, 2023 •

edited

Loading

Options file (`.vipgoci_options`)

Options file (`.vipgoci_options`)

Options file (`.vipgoci_options`)

Options file (`.vipgoci_options`)