Update unit and integration tests to comply with a common standard, PHP 8.2 fixes, template update #346

gudmdharalds · 2023-02-09T17:04:05Z

This pull request provides the following updates to the test suites:

Update unit tests to a common standard, including applying WordPress Coding Standards and the other requirements detailed in Clean up test suites #244 and is provided in the Skeleton.php file.
Updates a few integration tests in the same way. Further updates will need to wait until later.
Ensures unit tests work with PHP 8.2.
Adds a new item to the pull request template: Ensure only one function is tested per test file

TODO:

Changes listed above.
Add/update tests -- unit and/or integrated (if needed)
[N/A] Add to, or update, Scan run detail report as applicable
Check status of automated tests
Ensure PHPDoc comments are up to date for functions added or altered
Changelog entry (for VIP) [ Changelog for version 1.3.4 #333 ]

wpcomvip-vipgoci-bot

Code analysis identified issues

VIP Code Analysis Bot has identified potential problems in this pull request during automated scanning. We recommend reviewing the issues noted and that they are resolved.

phpcs scanning turned up:

🚫 10 errors

This bot provides automated PHP linting and PHPCS scanning. For more information about the bot and available customizations, see our documentation.

Scan run detail

Software versions vip-go-ci version: `1.3.3` PHP runtime version for vip-go-ci: `8.1.15` PHP runtime for linting: PHP 8.1: `8.1.15` PHP runtime version for PHPCS: `7.4.33` PHPCS version: `3.7.1` PHP runtime version for SVG scanner: `7.4.33` Options file (`.vipgoci_options`) Options file enabled: `true` Configurable options: `skip-execution` `skip-draft-prs` `lint-modified-files-only` `phpcs` `phpcs-severity` `phpcs-sniffs-include` `phpcs-sniffs-exclude` `report-no-issues-found` `review-comments-sort` `review-comments-include-severity` `post-generic-pr-support-comments` `review-comments-sort` `scan-details-msg-include` `svg-checks` `autoapprove` `autoapprove-php-nonfunctional-changes` Options altered: `phpcs-severity`set to`1` `phpcs-sniffs-include`set to`Generic.PHP.DisallowShortOpenTag, Squiz.PHP.CommentedOutCode` `phpcs-sniffs-exclude`set to`WordPress.Security.EscapeOutput, WordPress.PHP.DevelopmentFunctions, WordPress.WP.AlternativeFunctions, WordPress.PHP.DiscouragedPHPFunctions, WordPress.Files.FileName, Squiz.Commenting.FileComment, Generic.PHP.Syntax` `skip-draft-prs`set to	PHP lint options PHP lint files enabled: `true` Lint modified files only: `true` Lint files with file extensions: `php` Directories not PHP linted: None SVG configuration SVG scanning enabled: `true` Scan added/modified files with file extensions: `svg` Auto-approval configuration Auto-approvals enabled: `true` Non-functional changes auto-approved: `true` Files with file extensions to consider for non-functional change auto-approval: `php` Auto-approved file-types: `css` `csv` `eot` `gif` `gz` `ico` `ini` `jpeg` `jpg` `json` `less` `map` `md` `mdown` `mo` `mp4` `otf` `pcss` `pdf` `po` `pot` `png` `sass` `scss` `styl` `ttf` `txt` `woff` `woff2` `yml`	PHPCS configuration PHPCS scanning enabled: `true` PHPCS severity level: `1` Standard(s) used: `PHPCompatibility` `PHPCompatibilityParagonieRandomCompat` `PHPCompatibilityParagonieSodiumCompat` `VariableAnalysis` `WordPress` Runtime set: `testVersion 8.1-` Scan added/modified files with file extensions: `php` `js` `twig` Custom sniffs included: `Generic.PHP.DisallowShortOpenTag` `Squiz.PHP.CommentedOutCode` Custom sniffs excluded: `WordPress.Security.EscapeOutput` `WordPress.PHP.DevelopmentFunctions` `WordPress.WP.AlternativeFunctions` `WordPress.PHP.DiscouragedPHPFunctions` `WordPress.Files.FileName` `Squiz.Commenting.FileComment` `Generic.PHP.Syntax` Directories not PHPCS scanned: None WPScan API configuration WPScan API scanning enabled: `true` WPScan API URL: `https://wpscan.com/api/v3` Directories scanned: `plugins` `client-mu-plugins` `themes` Directories not scanned: None Scan added/modified plugins based on headers present in files with file extensions: `php` Scan added/modified themes based on headers present in files with file extensions: `css`

tests/integration/GitHubOrgTeamsTest.php

tests/integration/GitHubStatusCreateTest.php

tests/integration/GitHubTeamMembersManyTest.php

tests/integration/GitHubTeamMembersTest.php

tests/integration/OptionsTeamsTest.php

wpcomvip-vipgoci-bot · 2023-02-14T13:40:05Z

Scanning latest commit did not yield any new issues. Please have a look at older feedback still existing (commit-ID: ab8c270)

This bot provides automated PHP linting and PHPCS scanning. For more information about the bot and available customizations, see our documentation.

Scan run detail

Software versions vip-go-ci version: `1.3.3` PHP runtime version for vip-go-ci: `8.1.15` PHP runtime for linting: PHP 8.1: `8.1.15` PHP runtime version for PHPCS: `7.4.33` PHPCS version: `3.7.1` PHP runtime version for SVG scanner: `7.4.33` Options file (`.vipgoci_options`) Options file enabled: `true` Configurable options: `skip-execution` `skip-draft-prs` `lint-modified-files-only` `phpcs` `phpcs-severity` `phpcs-sniffs-include` `phpcs-sniffs-exclude` `report-no-issues-found` `review-comments-sort` `review-comments-include-severity` `post-generic-pr-support-comments` `review-comments-sort` `scan-details-msg-include` `svg-checks` `autoapprove` `autoapprove-php-nonfunctional-changes` Options altered: `phpcs-severity`set to`1` `phpcs-sniffs-include`set to`Generic.PHP.DisallowShortOpenTag, Squiz.PHP.CommentedOutCode` `phpcs-sniffs-exclude`set to`WordPress.Security.EscapeOutput, WordPress.PHP.DevelopmentFunctions, WordPress.WP.AlternativeFunctions, WordPress.PHP.DiscouragedPHPFunctions, WordPress.Files.FileName, Squiz.Commenting.FileComment, Generic.PHP.Syntax` `skip-draft-prs`set to	PHP lint options PHP lint files enabled: `true` Lint modified files only: `true` Lint files with file extensions: `php` Directories not PHP linted: None SVG configuration SVG scanning enabled: `true` Scan added/modified files with file extensions: `svg` Auto-approval configuration Auto-approvals enabled: `true` Non-functional changes auto-approved: `true` Files with file extensions to consider for non-functional change auto-approval: `php` Auto-approved file-types: `css` `csv` `eot` `gif` `gz` `ico` `ini` `jpeg` `jpg` `json` `less` `map` `md` `mdown` `mo` `mp4` `otf` `pcss` `pdf` `po` `pot` `png` `sass` `scss` `styl` `ttf` `txt` `woff` `woff2` `yml`	PHPCS configuration PHPCS scanning enabled: `true` PHPCS severity level: `1` Standard(s) used: `PHPCompatibility` `PHPCompatibilityParagonieRandomCompat` `PHPCompatibilityParagonieSodiumCompat` `VariableAnalysis` `WordPress` Runtime set: `testVersion 8.1-` Scan added/modified files with file extensions: `php` `js` `twig` Custom sniffs included: `Generic.PHP.DisallowShortOpenTag` `Squiz.PHP.CommentedOutCode` Custom sniffs excluded: `WordPress.Security.EscapeOutput` `WordPress.PHP.DevelopmentFunctions` `WordPress.WP.AlternativeFunctions` `WordPress.PHP.DiscouragedPHPFunctions` `WordPress.Files.FileName` `Squiz.Commenting.FileComment` `Generic.PHP.Syntax` Directories not PHPCS scanned: None WPScan API configuration WPScan API scanning enabled: `true` WPScan API URL: `https://wpscan.com/api/v3` Directories scanned: `plugins` `client-mu-plugins` `themes` Directories not scanned: None Scan added/modified plugins based on headers present in files with file extensions: `php` Scan added/modified themes based on headers present in files with file extensions: `css`

gdh added 30 commits February 6, 2023 21:01

WP CS comment

ae6d095

WP CS updates

17e6e91

Removing '// phpcs:disable PSR1.Files.SideEffects'

0b19cbe

Removing '// phpcs:disable PSR1.Files.SideEffects'

b8df145

Syntax fix

0cc1401

Apply WP CS

9eb6f8c

Apply WP CS

0a7b77c

Apply WP CS

efbf64c

Apply WP CS

ab543c2

Apply WP CS

db0df5e

Apply WP CS

9766fd8

Apply WP CS

4540a85

Apply WP CS

5f58fe4

Apply WP CS

84cba92

Apply WP CS

731484b

Apply WP CS

cb6ecae

Apply WP CS

d0d6402

Apply WP CS, changes due to separate processes

5897ba1

Apply WP CS

167355a

Apply WP CS

946a1fd

Renaming file

13bd742

Renaming class

2e20a50

Apply WP CS

35284c7

Rename class

a0658b4

Rename file

d7e45c8

Rename file

70cd0fd

Rename class

8bd198c

Apply WP CS

2fce1bb

Apply WP CS

65a36d5

Apply WP CS

c4402b3

gdh added 13 commits February 13, 2023 19:29

Update setUp() to be a protected function

e6c6ac9

Update setUp() to be a protected function

ca9710f

Update setUp() to be a protected function

0008605

Update setUp() to be a protected function

73973f3

Update setUp() to be a protected function

43f4eda

Update setUp() to be a protected function

d595b65

Update setUp() to be a protected function

fbd1ef8

Update setUp() to be a protected function

e19c9fc

Update tearDown() to be a protected function

bad3375

Update tearDown() to be a protected function

189d47a

Update tearDown() to be a protected function

0a2ac31

Update tearDown() to be a protected function

074bf0d

Update tearDown() to be a protected function

91a0e68

wpcomvip-vipgoci-bot requested changes Feb 13, 2023

View reviewed changes

gdh added 13 commits February 14, 2023 10:25

Apply WP CS

1b16fe9

Apply WP CS

7e726ea

Apply WP CS

8989ea2

Apply WP CS

71716dd

Apply WP CS

ec87a63

Apply WP CS

07e8543

Update comment

911ac93

Update @var

d8e9ed1

Use phpcs:disable

5488954

Update comment

df28b52

Switch to phpcs:disable

016215a

Switch to using phpcs:disable

3f06aea

Removing code not needed

ab8c270

gudmdharalds merged commit 4ad877d into trunk Feb 14, 2023

gudmdharalds deleted the update/tests-common-standard branch February 14, 2023 13:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update unit and integration tests to comply with a common standard, PHP 8.2 fixes, template update #346

Update unit and integration tests to comply with a common standard, PHP 8.2 fixes, template update #346

Uh oh!

gudmdharalds commented Feb 9, 2023 •

edited

Loading

Uh oh!

wpcomvip-vipgoci-bot left a comment

Software versions

Options file (`.vipgoci_options`)

PHP lint options

SVG configuration

Auto-approval configuration

PHPCS configuration

WPScan API configuration

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wpcomvip-vipgoci-bot commented Feb 14, 2023

Software versions

Options file (`.vipgoci_options`)

PHP lint options

SVG configuration

Auto-approval configuration

PHPCS configuration

WPScan API configuration

Uh oh!

Uh oh!

Update unit and integration tests to comply with a common standard, PHP 8.2 fixes, template update #346

Update unit and integration tests to comply with a common standard, PHP 8.2 fixes, template update #346

Uh oh!

Conversation

gudmdharalds commented Feb 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpcomvip-vipgoci-bot left a comment

Choose a reason for hiding this comment

Code analysis identified issues

Software versions

Options file (.vipgoci_options)

PHP lint options

SVG configuration

Auto-approval configuration

PHPCS configuration

WPScan API configuration

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wpcomvip-vipgoci-bot commented Feb 14, 2023

Software versions

Options file (.vipgoci_options)

PHP lint options

SVG configuration

Auto-approval configuration

PHPCS configuration

WPScan API configuration

Uh oh!

Uh oh!

gudmdharalds commented Feb 9, 2023 •

edited

Loading

Options file (`.vipgoci_options`)

Options file (`.vipgoci_options`)