You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request updates the "local" slug determination mechanism to better determine slugs for add-ons placed in subdirectories. This should improve WordPress.org add-on detection.
This is accomplished by a change in logic:
The vipgoci_wpcore_misc_determine_local_slug() function is updated to ensure directory name is included in "local" slug only when there are more than two directories in the relative path. This ensures that the "local" slug only contains directory name when there is an add-on directory present and not just the base directory.
Call to vipgoci_wpcore_misc_determine_local_slug() includes a relative file path.
Some changes are to make the above possible but also to make the code easier to maintain and understand:
Update vipgoci_wpcore_misc_scan_directory_for_addons() to require two parameters instead of one: Parameter for full path to file and a relative git repository path.
Updates functions that depend on both functions so to include both relative and full paths.
These changes should lead to better detection of add-ons and cleaner code.
TODO:
Added patch for improved "local" slug determination.
Update function calls to include new parameters.
Update tests to accommodate the new "local" slug determination mechanism.
[N/A] Add to, or update, Scan run detail report as applicable
Check status of automated tests
Ensure PHPDoc comments are up to date for functions added or altered
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the "local" slug determination mechanism to better determine slugs for add-ons placed in subdirectories. This should improve WordPress.org add-on detection.
This is accomplished by a change in logic:
vipgoci_wpcore_misc_determine_local_slug()function is updated to ensure directory name is included in "local" slug only when there are more than two directories in the relative path. This ensures that the "local" slug only contains directory name when there is an add-on directory present and not just the base directory.vipgoci_wpcore_misc_determine_local_slug()includes a relative file path.Some changes are to make the above possible but also to make the code easier to maintain and understand:
vipgoci_wpcore_misc_scan_directory_for_addons()to require two parameters instead of one: Parameter for full path to file and a relative git repository path.These changes should lead to better detection of add-ons and cleaner code.
TODO:
Scan run detailreport as applicablePHPDoccomments are up to date for functions added or altered