This repository was archived by the owner on Feb 17, 2025. It is now read-only.
Club: Refining spacing #6375
Merged
Club: Refining spacing #6375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jffng
reviewed
Aug 11, 2022
| @@ -1,6 +1,10 @@ | |||
| <!-- wp:template-part {"slug":"header","tagName":"header"} /--> | |||
|
|
|||
| <!-- wp:query-title {"type":"archive","level":2} /--> | |||
| <!-- wp:query-title {"type":"archive"} /--> | |||
There was a problem hiding this comment.
I noticed on mobile this increase in font size may easily cut off the word / push beyond the width of the screen:
There was a problem hiding this comment.
We are using the font size from the design there.
jffng
reviewed
Aug 11, 2022
| @@ -366,11 +366,6 @@ | |||
| "style": "solid", | |||
| "width": "0" | |||
| }, | |||
| "spacing": { | |||
There was a problem hiding this comment.
Just want to make sure this is intentional to remove this? I think it looks better but wasn't sure if it's a part of this PR.
There was a problem hiding this comment.
Yep, it's intentional double spacing at the left of the quote.
jffng
reviewed
Aug 11, 2022
There was a problem hiding this comment.
Hello @matiasbenedetto, the PR looks mostly good, I just left two small comments.
jffng
approved these changes
Aug 12, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Club:
Index (desktop)
Index (mobile)
Archives (desktop):
Archives (mobile):