Skip to content
This repository was archived by the owner on Feb 17, 2025. It is now read-only.

Conversation

pbking
Copy link
Contributor

@pbking pbking commented Jun 6, 2022

This changes the templates (and template parts) folder location from the old location to the new. It also updates the "pattern registration" that registers Blockbase's template parts as patterns.

Intended for Blockbase 3

@pbking pbking added this to the Blockbase 3.0 milestone Jun 6, 2022
@pbking pbking requested a review from a team June 6, 2022 14:55
Copy link
Contributor

@MaggieCabrera MaggieCabrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes LGTM but I wonder if we should divide this into two PRs to avoid breakage during deploy. I've had that happened to me when renaming an included file, don't know if this would be the case for dotcom, you may get alerts even if for just a few minutes.

@mikachan mikachan linked an issue Jun 9, 2022 that may be closed by this pull request
pbking added a commit that referenced this pull request Jul 20, 2022
Refactor/blockbase color admin (#6043)
Moved templates from old folder location to new (#6073)
Blockbase: Implement the Button elements API (#6041)
Blockbase: Implement Comment Block and removed CSS (#6080)
Fix/migrate blockbase font self hosted (#6123)
Blockbase children: update comments block (#6153)
Blockbase: Changed the trigger to render social icons (#6079)
Blockbase: move button padding styles from ponyfill to theme.json (#5901)

Co-authored-by: Grant Kinney <hi@grant.mk>
Co-authored-by: Jeremy Yip <jeremy.yip@automattic.com>
Co-authored-by: MaggieCabrera <maggie.cabrera@automattic.com>
Co-authored-by: madhusudhand <madhusudhan.dollu@gmail.com>
@pbking pbking mentioned this pull request Jul 20, 2022
@pbking
Copy link
Contributor Author

pbking commented Jul 20, 2022

Closing: Work merged in #6167

@pbking pbking closed this Jul 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blockbase: Update name of template directories
2 participants