DevDocs: Gutenberg components - Updating examples #26367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f8402d4 to
72bf72c
Compare
This was referenced Aug 5, 2018
Closed
|
@gziolo let me know when the new version of the |
|
It will happen today, we were too busy preparing plugin's release yesterday :) |
768bf9d to
840e08f
Compare
|
I forgot to let you know but I see you already noticed that new version of packages was published 😎 |
840e08f to
ed0783e
Compare
This was referenced Aug 11, 2018
4397dae to
5003c61
Compare
Adding compatibility for components having a name that doesn't match the file path
The section is now behind a feature flag
The section is now behind a feature flag
Adding section back to the Collection component
Added more context explaining how the examples are extracted
Amending class name
d73030b to
0d2b951
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This continues #26314 and includes examples of the remaining Gutenberg components in the new "Gutenberg Components" section.
Examples are loaded dynamically from Gutenberg (WordPress/gutenberg#8267, WordPress/gutenberg#8338), so we don't need to maintain then anymore in Calypso.
Due to issues found, the new "Gutenberg Components" section is now behind the same feature flag we added in #26065, so it is only visible in a development environment.
Testing Instructions
With the
devdocs/gutenberg-blocksfeature flag enabled:npm start/devdocs/gutenberg-componentsWith the
devdocs/gutenberg-blocksfeature flag disabled:DISABLE_FEATURES=devdocs/gutenberg-blocks npm start/devdocs/devdocs/gutenberg-componentsIssues
ColorIndicator: It has not been publishedColorPalette: Custom color picker is wrong positioned (ColorPalette: Custom color picker is wrong positioned WordPress/gutenberg#8558)DatePicker: Prev/Next month buttons wrong styled (DateTimePicker: Previous/Next month wrongly styled WordPress/gutenberg#8870)Dropdown: Popover content is wrong positioned (Dropdown: Popover content is wrong positioned WordPress/gutenberg#8559)FocusableIframe: React does not recognize theforwardedRefprop on a DOM element (FocusableIframe: React does not recognize the forwardedRef prop on a DOM element WordPress/gutenberg#8560)FormToggle: Component wrong styled (FormToggle: Component wrongly styled WordPress/gutenberg#8871)Modal: Height is bigger than needed and tooltip is wrong positioned (Modal: Height is bigger than needed and tooltip is wrong positioned WordPress/gutenberg#8561)NavigableContainer: Items in TabbableContainer are not navigated in order (NavigableContainer: Items in TabbableContainer are not navigated in order WordPress/gutenberg#8563)Notice: Component wrongly styledPlaceholder: Width exceeds the width of the parent (Placeholder: Width exceeds the width of the parent WordPress/gutenberg#8564)SandBox: Content not displayed (SandBox: Content not displayed WordPress/gutenberg#8565)Spinner: Nothing is displayedwithFilters: Filter is not applied