Limit playback position changes when switching episodes #3383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the changes position on the scrubber from the lock screen and we are switching episodes, it seems that we sometimes run into race conditions where the episode is skipped. The remote command doesn't give us any info about the media item but we can track when the episode changes from our own internal notifications. For now, I've set a delay of 2 seconds since that seems like a reasonable amount of time where trying again would work.
podcasts/PlaybackManager.swift
Outdated
| if FeatureFlag.limitPlaybackPositionChanges.enabled { | ||
| // Check if we're still in the limiting window after an episode change | ||
| if let switchTime = episodeSwitchTime, | ||
| Date().timeIntervalSince(switchTime) < 2.0 { |
There was a problem hiding this comment.
Just a small nit: Can we switch Date() to Date.now just find it a bit more explicit that is current date.
SergioEstevao
approved these changes
Aug 1, 2025
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1359
When the changes position command from the lock screen happens while we are switching episodes, it seems that we sometimes run into race conditions where the episode is skipped. The remote command doesn't give us any info about the media item but we can track when the episode changes from our own internal notifications. For now, I've set a delay of 2 seconds since that seems like a reasonable amount of time where trying again would work.
The
limitPlaybackPositionChangesflag controls these changes.To test
Episode switching
Normal scrubbing
One way you can tell this is being caught without checking the logs is that the scrub command may provide haptic feedback when it fails, this should mean the new code caught the case and, if you try again, scrubbing will work.
Checklist
CHANGELOG.mdif necessary.