Skip to content

[New onboarding] Tweaks after design review #3372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Aug 1, 2025
Merged

[New onboarding] Tweaks after design review #3372

merged 17 commits into from
Aug 1, 2025

Conversation

SergioEstevao
Copy link
Contributor

@SergioEstevao SergioEstevao commented Jul 31, 2025 •
edited
Loading

| 📘 Part of: # |
|:---:|

Fixes ##3370

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-07-31.at.19.59.04.mp4

To test

  1. Start the application with an user without a Subscription
  2. Ensure that you have newOnboardingUpgrade FF active
  3. Ensure that you follow one Podcast
  4. Open the Podcasts Tab
  5. Open a Podcast
  6. Tap on the add to Folders icon
  7. Check if the Upgrade screen is show with the correct custom message for Folders
  8. Check if the contextual animation for Folders is working correct
  9. Check if the tweaks mentioned in this ticket are addressed Contextual upgrade - animation tweaks #3370
  10. Tap on See All Features button on the top
  11. Smoke test is using other themes and other entry points for folders: Folders icon on Podcasts

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@SergioEstevao SergioEstevao added this to the 7.95 milestone Jul 31, 2025
@SergioEstevao SergioEstevao requested a review from dcamozzi July 31, 2025 10:48
@dangermattic
Copy link
Collaborator

dangermattic commented Jul 31, 2025 •
edited
Loading

1 Warning
⚠️ View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.

Generated by 🚫 Danger

@SergioEstevao SergioEstevao marked this pull request as ready for review July 31, 2025 10:51
@SergioEstevao SergioEstevao requested a review from a team as a code owner July 31, 2025 10:51
@SergioEstevao SergioEstevao requested review from danielebogo and bjtitus and removed request for a team July 31, 2025 10:51
@pocketcasts
Copy link
Contributor

pocketcasts commented Jul 31, 2025 •
edited
Loading

App Icon📲 You can test the changes from this Pull Request in Pocket Casts Prototype Build by scanning the QR code below to install the corresponding build.
App NamePocket Casts Prototype Build
Build Number11277
VersionPR #3372
Bundle IDau.com.shiftyjelly.podcasts.prototype
Commitc0d03e8
Installation URL00pciupefs4lg
 Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@SergioEstevao SergioEstevao requested review from david-gonzalez-a8c and removed request for dcamozzi July 31, 2025 11:34
@david-gonzalez-a8c
Copy link

The size of the animation and header look much better, thank you!

I'm realizing now that the covers after the folders get formed have different rounded corners, and some have straight corners. We should also make the spacing between each cover consistent before the folders are formed (sorry I can't take a screenshot, but the alert about the payment won't let me).

Regarding the scroll down animation, let's make it so the folder assets can't be seen after scrolling down (you can see a bit of the blue and green folders). The animation and ease out can be tweaked too, I'd love something like this:

scroll.down.anim.mov

I created this animation in Figma with a duration of 1200ms and the following values for the animation curve:

Screenshot 2025-07-31 at 8 12 02 PM

@SergioEstevao
Copy link
Contributor Author

@david-gonzalez-a8c thanks for the review, I just addressed your comments and put a new build up for review

bjtitus
bjtitus approved these changes Aug 1, 2025
View reviewed changes
Copy link
Contributor

@bjtitus bjtitus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Folders upgrade screen shows coming from Podcast list
✅ Folders upgrade screen shows coming from Podcast page
✅ Animation + layout looks good
✅ Bookmarks shows from shelf action + Profile > Bookmarks > Get Bookmarks

@SergioEstevao SergioEstevao merged commit cff47a6 into trunk Aug 1, 2025
4 of 6 checks passed
@SergioEstevao SergioEstevao deleted the sergio/new_onboarding_tweaks branch August 1, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjtitus bjtitus bjtitus approved these changes

@david-gonzalez-a8c david-gonzalez-a8c david-gonzalez-a8c approved these changes

@danielebogo danielebogo Awaiting requested review from danielebogo danielebogo is a code owner automatically assigned from Automattic/pocket-casts-ios

Assignees
No one assigned
Labels
New Onboarding
Projects
None yet
Milestone
7.95
Development

Successfully merging this pull request may close these issues.
5 participants
@SergioEstevao @dangermattic @pocketcasts @david-gonzalez-a8c @bjtitus