Skip to content

Fix the trending notification message #3351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 27, 2025
Merged

Fix the trending notification message #3351

merged 2 commits into from
Jul 27, 2025

Conversation

geekygecko
Copy link
Member

Description

This change improves the "Trending this week" notification message.

Testing Instructions

  1. Start the app with a user that isn't logged in
  2. In order to speed up notifications delivery go to Settings -> Developer Menu and tap on "Speed Up Notifications"
  3. Go to Settings -> Notifications
  4. Turn all the notifications off apart from the "Trending & Recommendation"
  5. Switch to another app
  6. Wait for 60 seconds and see if a notification shows up
  7. Tap on the notification
  8. ✅ Verify the notification text looks correct

Screenshot

Simulator Screenshot - iPhone 16 - 2025-07-24 at 14 13 09

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@geekygecko geekygecko marked this pull request as ready for review July 24, 2025 04:52
@geekygecko geekygecko requested a review from a team as a code owner July 24, 2025 04:52
@geekygecko geekygecko requested review from danielebogo and removed request for a team July 24, 2025 04:52
@geekygecko geekygecko added this to the 7.95 milestone Jul 24, 2025
danielebogo
danielebogo approved these changes Jul 24, 2025
View reviewed changes
Copy link
Contributor

@danielebogo danielebogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good :shipit: ! Thanks for the fix!

IMG_0266

@geekygecko geekygecko merged commit 892de91 into trunk Jul 27, 2025
7 of 10 checks passed
@geekygecko geekygecko deleted the philip/notification-message branch July 27, 2025 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielebogo danielebogo danielebogo approved these changes

Assignees
No one assigned
Labels
[Project] Notifications Revamp [Type] Enhancement Improve an existing feature.
Projects
None yet
Milestone
7.95
Development

Successfully merging this pull request may close these issues.
2 participants
@geekygecko @danielebogo