Skip to content

Do not switch file if we already have the streamed file being played #3432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 20, 2025
Merged

Do not switch file if we already have the streamed file being played #3432

merged 4 commits into from
Aug 20, 2025

Conversation

SergioEstevao
Copy link
Contributor

@SergioEstevao SergioEstevao commented Aug 20, 2025 •
edited
Loading

| 📘 Part of: # |
|:---:|

Fixes PCIOS-55

To test

  1. Start
  2. Enable the FF doNotSwitchToDownloadedFile in the Profile -> Settings -> Beta Features menu
  3. Ensure that you do not have Trim Silence active
  4. Start playing an episode of a podcast that you still didn't download
  5. Check if you hear any "pop" sound when the episode downloads. You can start the download of episode after you start playing it to check the exact moment
  6. Enable "Trim Silence" globally
  7. Play another episode that is not downloaded
  8. Check that this time your hear the "pop" when the download is finished. this is because the app needs to switch to the EffectsPlayer
  9. Now disable the Trim Silence effect while the episode is playing
  10. Switch to another episode that you didn't played before
  11. Check that it plays correctly

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@SergioEstevao SergioEstevao added this to the 7.96 ❄️ milestone Aug 20, 2025
@SergioEstevao SergioEstevao added the playback Issues related to playback label Aug 20, 2025
@dangermattic
Copy link
Collaborator

dangermattic commented Aug 20, 2025 •
edited
Loading

1 Warning
⚠️ This PR is assigned to the milestone 7.96 ❄️. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@SergioEstevao SergioEstevao changed the title Sergio/fix skip to 7 96 Do not switch file if we already have the streamed file being played Aug 20, 2025
@SergioEstevao SergioEstevao marked this pull request as ready for review August 20, 2025 11:33
@SergioEstevao SergioEstevao requested a review from a team as a code owner August 20, 2025 11:33
@SergioEstevao SergioEstevao mentioned this pull request Aug 20, 2025
Closed
3 tasks
danielebogo
danielebogo approved these changes Aug 20, 2025
View reviewed changes
Copy link
Contributor

@danielebogo danielebogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@SergioEstevao SergioEstevao merged commit 0878d62 into release/7.96 Aug 20, 2025
5 of 7 checks passed
@SergioEstevao SergioEstevao deleted the sergio/fix_skip_to_7_96 branch August 20, 2025 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielebogo danielebogo danielebogo approved these changes

Assignees
No one assigned
Labels
playback Issues related to playback
Projects
None yet
Milestone
7.96
Development

Successfully merging this pull request may close these issues.
3 participants
@SergioEstevao @dangermattic @danielebogo