Replace how to upload images with swiftui views #3401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssibility for images used in HowToUploadViewController
Increase hover circle x offset 1 point to the right
Clarified image subview names
Co-authored-by: Brandon Titus <b@titus.io>
Co-authored-by: Brandon Titus <b@titus.io>
…ges into ViewBuilders
Generated by 🚫 Danger |
…h-swiftui-views # Conflicts: # podcasts/Strings+Generated.swift # podcasts/UploadedViewController.swift
Instead of 1 and 2, let's refer to these by their contents for share menu and action instead.
|
This has already been reviewed in #2967 but can you give it a once over @danielebogo? |
danielebogo
reviewed
Aug 6, 2025
There was a problem hiding this comment.
Hey @bjtitus for these 2 key that have been changed do we need to wait for Glot press to be re-translated?: how_to_upload_second_instruction and how_to_upload_first_instruction
Also we can run CI on the external contributor PR directly
danielebogo
approved these changes
Aug 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution from @teaseaque in #2967
Fixes #7
Before testing
If the test device system language is English, add a non-English language that is supported by Pocket Casts (e.g. French) in Settings app > General > Language & Region. Then, set the preferred language for Pocket Casts to the non-English language in Settings app > Apps > Pocket Casts
Test
Checklist
CHANGELOG.mdif necessary.