Skip to content

Recreated hardcoded how-to-upload images as localizable SwiftUI views #2967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Aug 7, 2025
Merged

Recreated hardcoded how-to-upload images as localizable SwiftUI views #2967

merged 8 commits into from
Aug 7, 2025

Conversation

teaseaque
Copy link
Contributor

📘 Part of: #7

Fixes #7

  • Added 2 SwiftUI views that support themes and text localization to replace 2 images including hardcoded English text on HowToUploadViewController sheet
  • Removed hardcoded English image assets and references since they are no longer used to reduce bundle size

Before testing

If the test device system language is English, add a non-English language that is supported by Pocket Casts (e.g. French) in Settings app > General > Language & Region. Then, set the preferred language for Pocket Casts to the non-English language in Settings app > Apps > Pocket Casts

Test

  1. Run this branch
  2. Navigate to HowToUploadViewController sheet via Profile > Files > How do I do that?
  3. Observe the 2 images between instructions are in the preferred language
  4. Change the Pocket Casts theme and repeat steps 2 & 3

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@teaseaque teaseaque requested a review from a team as a code owner April 12, 2025 17:48
@teaseaque teaseaque requested review from bjtitus and removed request for a team April 12, 2025 17:48
@CLAassistant
Copy link

CLAassistant commented Apr 12, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@teaseaque teaseaque mentioned this pull request Apr 12, 2025
Closed
@teaseaque
Copy link
Contributor Author

Hi @bjtitus, just checking in on this PR - I appreciate your help before and any further feedback. Hoping fixing lucky issue #7 brings some good merge karma!

bjtitus
bjtitus requested changes May 13, 2025
View reviewed changes
Copy link
Contributor

@bjtitus bjtitus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay @teaseaque. I left a few comments about overall code structure but it looks REALLY good in testing.

Do you think it would make sense to remove the HowToUploadViewController.xib or are there still useful pieces in there? We have a RoundedButton style that should work for the bottom button.

teaseaque and others added 3 commits May 13, 2025 13:06
@teaseaque @bjtitus
Add didMove for image2HostVC
83ed8b2 
Co-authored-by: Brandon Titus <b@titus.io>
@teaseaque @bjtitus
Add didMove for image1HostVC
92c3c2c 
Co-authored-by: Brandon Titus <b@titus.io>
@teaseaque
Simplified HowToUploadViewController using SwiftUI and refactored ima…
bbd0449 
…ges into ViewBuilders
@teaseaque
Copy link
Contributor Author

Hey @bjtitus, all good, thanks for the feedback! I made updates for your feedback to refactor using ViewBuilders, plus replace HowToUploadViewController.swift and .xib with HowToUploadView.swift. Now tapping "Done" has some tactile feedback, too.

@teaseaque
Copy link
Contributor Author

Hey @bjtitus or @SergioEstevao, just revisiting this - can you please help merge this PR and close out the issue? I completed your suggested changes and really appreciate the opportunity to contribute!

@bjtitus bjtitus self-requested a review August 4, 2025 16:53
@bjtitus
Copy link
Contributor

bjtitus commented Aug 4, 2025

@TEAMMATE I'm so sorry for the delay. Thanks for looping back to us. I'm taking a look today.
Do you mind if I clean up merge conflicts for you? We will need create a separate branch so our CI can properly run (we don't run CI for outside contributions for security reasons).

@teaseaque
Copy link
Contributor Author

All good! And yep, sounds great!

@bjtitus
Copy link
Contributor

bjtitus commented Aug 4, 2025

Code looks much better, thank you! I probably won't be able to branch and trigger the CI build today but I'll do it first thing tomorrow.

@bjtitus bjtitus mentioned this pull request Aug 5, 2025
Merged
3 tasks
@bjtitus bjtitus merged commit ceb5c2c into Automattic:trunk Aug 7, 2025
2 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjtitus bjtitus Awaiting requested review from bjtitus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

I18n: images with English content
3 participants
@teaseaque @CLAassistant @bjtitus